Merge pull request #324 from Adyen/adjustment/removeStoredDeletionErr…

…orMessage Remove stored deletion error message
Adyen · Dec 20, 2024 · e6716d4 · e6716d4
2 parents adf1967 + 22082e0
commit e6716d4
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 37 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,8 +2,9 @@
 
 * Added support for partial payments.
 * Improved dynamic viewport of card component.
-* Added support of iDEAL to the Instant Component. 
+* Added support of iDEAL to the Instant Component.
 * Added the missing loading bottom sheet for the advanced flow google pay component.
+* Removed alert in case the deletion of stored payment method failed.
 * Updated iOS SDK to v5.14.0.
 * Updated Android SDK to v5.8.0. Gradle v8 is now mandatory.
 

diff --git a/android/src/main/kotlin/com/adyen/checkout/flutter/dropIn/advanced/AdvancedDropInService.kt b/android/src/main/kotlin/com/adyen/checkout/flutter/dropIn/advanced/AdvancedDropInService.kt
@@ -200,13 +200,7 @@ class AdvancedDropInService : DropInService(), LifecycleOwner {
         return if (deleteStoredPaymentMethodResultDTO?.isSuccessfullyRemoved == true) {
             RecurringDropInServiceResult.PaymentMethodRemoved(deleteStoredPaymentMethodResultDTO.storedPaymentMethodId)
         } else {
-            // TODO - the error message should be provided by the native SDK
-            RecurringDropInServiceResult.Error(
-                errorDialog =
-                    ErrorDialog(
-                        message = "Removal of the stored payment method failed. Please try again later."
-                    )
-            )
+            RecurringDropInServiceResult.Error(errorDialog = null)
         }
     }
 

diff --git a/android/src/main/kotlin/com/adyen/checkout/flutter/dropIn/session/SessionDropInService.kt b/android/src/main/kotlin/com/adyen/checkout/flutter/dropIn/session/SessionDropInService.kt
@@ -50,13 +50,7 @@ class SessionDropInService : SessionDropInService(), LifecycleOwner {
         return if (deleteStoredPaymentMethodResultDTO?.isSuccessfullyRemoved == true) {
             RecurringDropInServiceResult.PaymentMethodRemoved(deleteStoredPaymentMethodResultDTO.storedPaymentMethodId)
         } else {
-            // TODO - the error message should be provided by the native SDK
-            RecurringDropInServiceResult.Error(
-                errorDialog =
-                    ErrorDialog(
-                        message = "Removal of the stored payment method failed. Please try again later."
-                    )
-            )
+            RecurringDropInServiceResult.Error(errorDialog = null)
         }
     }
 

diff --git a/ios/Classes/dropIn/dropInAdvancedFlow/DropInAdvancedFlowStoredPaymentMethodsDelegate.swift b/ios/Classes/dropIn/dropInAdvancedFlow/DropInAdvancedFlowStoredPaymentMethodsDelegate.swift
@@ -24,11 +24,6 @@ class DropInAdvancedFlowStoredPaymentMethodsDelegate: StoredPaymentMethodsDelega
     }
 
     func handleDisableResult(isSuccessfullyRemoved: Bool) {
-        if isSuccessfullyRemoved == false {
-            let errorAlert = TemporaryAlertHelper.buildPaymentMethodDeletionErrorAlert()
-            viewController.adyen.topPresenter.present(errorAlert, animated: true)
-        }
-
         completionHandler?(isSuccessfullyRemoved)
     }
 }
diff --git a/ios/Classes/dropIn/dropInSessions/DropInSessionsStoredPaymentMethodsDelegate.swift b/ios/Classes/dropIn/dropInSessions/DropInSessionsStoredPaymentMethodsDelegate.swift
@@ -24,11 +24,6 @@ class DropInSessionsStoredPaymentMethodsDelegate: StoredPaymentMethodsDelegate {
     }
 
     func handleDisableResult(isSuccessfullyRemoved: Bool) {
-        if isSuccessfullyRemoved == false {
-            let errorAlert = TemporaryAlertHelper.buildPaymentMethodDeletionErrorAlert()
-            viewController.adyen.topPresenter.present(errorAlert, animated: true)
-        }
-
         completionHandler?(isSuccessfullyRemoved)
     }
 }
diff --git a/ios/Classes/utils/TemporaryAlertHelper.swift b/ios/Classes/utils/TemporaryAlertHelper.swift