Improve example for session with multi components #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-SD
changed the title
LCOV of commit
|
|
descorp
reviewed
Jan 21, 2025
Comment on lines
+24
to
+30
| final cardComponentConfiguration = CardComponentConfiguration( | ||
| environment: Config.environment, | ||
| clientKey: Config.clientKey, | ||
| countryCode: Config.countryCode, | ||
| amount: Config.amount, | ||
| shopperLocale: Config.shopperLocale, | ||
| ); |
There was a problem hiding this comment.
Is it only CardComponent specific?
There was a problem hiding this comment.
It's used in two places, for the card component and for creating the sessions object. I'm considering exposing the underlying baseConfiguration class or creating a dedicated sessionCreationConfiguration class for requesting the session object. Then there is no need to reuse the card (or any other) configuration to create the session object. But this will happen in a separate PR.
descorp
reviewed
Jan 21, 2025
| _extractSchemePaymentMethod(sessionCheckout.paymentMethods); | ||
|
|
||
| return Padding( | ||
| padding: const EdgeInsets.fromLTRB(0, 0, 0, 0), |
There was a problem hiding this comment.
Padding is gone. Is this expected?
descorp
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.