-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Faster tests #1283
Closed
Closed
chore: Faster tests #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goergisn
added
the
chore
a pull request that has chore changes that shouldn't be in the release notes
label
Jul 24, 2023
descorp
reviewed
Jul 24, 2023
erenbesel
previously approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that 50 ms is enough!
goergisn
dismissed stale reviews from erenbesel and github-actions[bot]
via
July 24, 2023 16:00
9c37d53
erenbesel
previously approved these changes
Jul 25, 2023
goergisn
dismissed stale reviews from erenbesel and github-actions[bot]
via
July 25, 2023 11:16
4267218
goergisn
dismissed
github-actions[bot]’s stale review
October 6, 2023 13:40
The merge-base changed after approval.
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
XCTestCase+Wait
with helper methods to wait until a certain condition is met to replace unreliablewait(for:)
XCTestCase+RootViewController
with helper methods to setup the window.rootViewController, present on the root and speed up all animations for faster tests