Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Faster tests #1283

Closed
wants to merge 86 commits into from
Closed

chore: Faster tests #1283

wants to merge 86 commits into from

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jul 24, 2023

Changes

  • Removing long waiting times
  • Improving flakey tests and readability
  • Introducing XCTestCase+Wait with helper methods to wait until a certain condition is met to replace unreliable wait(for:)
  • Introducing XCTestCase+RootViewController with helper methods to setup the window.rootViewController, present on the root and speed up all animations for faster tests
  • Replicating local environment to ensure proper snapshot testing

@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Jul 24, 2023
github-actions[bot]
github-actions bot previously approved these changes Jul 24, 2023
@goergisn goergisn marked this pull request as ready for review July 24, 2023 13:27
erenbesel
erenbesel previously approved these changes Jul 24, 2023
Copy link
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that 50 ms is enough!

github-actions[bot]
github-actions bot previously approved these changes Jul 24, 2023
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2023
erenbesel
erenbesel previously approved these changes Jul 25, 2023
@goergisn goergisn marked this pull request as draft July 26, 2023 09:35
github-actions[bot]
github-actions bot previously approved these changes Aug 10, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 10, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 4, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 4, 2023
@goergisn goergisn dismissed github-actions[bot]’s stale review October 6, 2023 13:40

The merge-base changed after approval.

github-actions[bot]
github-actions bot previously approved these changes Oct 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@goergisn goergisn closed this Nov 20, 2023
@goergisn goergisn deleted the faster_tests branch January 29, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants