Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Allow co-branded bcmc #1304

Merged
merged 19 commits into from
Aug 24, 2023
Merged

new: Allow co-branded bcmc #1304

merged 19 commits into from
Aug 24, 2023

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Aug 9, 2023

Summary

  • Bancontact cards are now supported in the CardComponent
  • Dual-branded Bancontact cards now allow brand selection in the BCMCComponent
  • Adding type to BinLookupRequest for correct card brand sorting
  • Using CardPaymentMethod's brands to configure the BCMCComponent

@goergisn goergisn added the chore a pull request that has chore changes that shouldn't be in the release notes label Aug 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2023
@goergisn goergisn marked this pull request as draft August 9, 2023 14:52
github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2023
@goergisn goergisn marked this pull request as ready for review August 18, 2023 10:33
github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2023
@goergisn goergisn changed the title chore: Allow co-branded bcmc new: Allow co-branded bcmc Aug 18, 2023
@goergisn goergisn added new a pull request that adds a new feature and removed chore a pull request that has chore changes that shouldn't be in the release notes labels Aug 18, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 18, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 22, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 22, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 22, 2023
erenbesel
erenbesel previously approved these changes Aug 22, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

98.6% 98.6% Coverage
0.0% 0.0% Duplication

@goergisn goergisn merged commit 2da7c98 into develop Aug 24, 2023
10 checks passed
@goergisn goergisn deleted the COIOS-616_cobranded_bcmc branch August 24, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new a pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants