Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve FullScreenViewController compatibility with AlertViewController #1325

Merged
merged 11 commits into from
Sep 25, 2023

Conversation

descorp
Copy link
Contributor

@descorp descorp commented Aug 16, 2023

Open PR

Changes

  • Now SwiftUI helper supports AlertViewController

@descorp descorp added the fixed a pull request that fixes a bug label Aug 16, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 16, 2023
neelSharma12
neelSharma12 previously approved these changes Aug 16, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 16, 2023
github-actions[bot]
github-actions bot previously approved these changes Aug 16, 2023
goergisn
goergisn previously approved these changes Aug 16, 2023
@goergisn goergisn changed the title Improve FullScreenViewController compatibility with AlertViewController fix: Improve FullScreenViewController compatibility with AlertViewController Aug 21, 2023
github-actions[bot]
github-actions bot previously approved these changes Sep 1, 2023
github-actions[bot]
github-actions bot previously approved these changes Sep 1, 2023
github-actions[bot]
github-actions bot previously approved these changes Sep 1, 2023
@goergisn goergisn self-requested a review September 12, 2023 08:57
goergisn
goergisn previously approved these changes Sep 12, 2023
neelSharma12
neelSharma12 previously approved these changes Sep 12, 2023
github-actions[bot]
github-actions bot previously approved these changes Sep 12, 2023
@goergisn goergisn self-requested a review September 18, 2023 08:20
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

28.6% 28.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@descorp descorp merged commit d00069f into develop Sep 25, 2023
9 of 16 checks passed
@descorp descorp deleted the fix-swift-ui branch September 25, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed a pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants