Splitting responsibilities of analytics provider #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmamont
previously approved these changes
Oct 28, 2024
erenbesel
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
goergisn
previously approved these changes
Oct 30, 2024
erenbesel
dismissed stale reviews from goergisn, github-actions[bot], and atmamont
via
c6d4a9d
erenbesel
changed the title
atmamont
previously approved these changes
Nov 7, 2024
erenbesel
dismissed stale reviews from goergisn, atmamont, and github-actions[bot]
via
7aa6812
atmamont
approved these changes
Nov 8, 2024
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
goergisn
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits analytics provider responsibilities into two by moving the conditional follow up events on its own class
EventAnalyticsProviderwith the timer/batching logic.This object is only created by the context if the configuration is turned on.
The original analytics provider is now only responsible for the initial call, is not aware of any of the events provider's lifetime and only passes the calls to it.
Ticket
COIOS-815