Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax ticket validation regex #1887

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Relax ticket validation regex #1887

merged 1 commit into from
Nov 1, 2024

Conversation

atmamont
Copy link
Contributor

@atmamont atmamont commented Nov 1, 2024

Summary

Current rule matching COIOS-XXX is too strict and doesn't work when changes are coming from another stream (example).
This changes matching from "COIOS" to "any string".

Ticket

COIOS-000

@atmamont atmamont added the chore a pull request that has chore changes that shouldn't be in the release notes label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ No changes detected

Comparing https://github.com/Adyen/adyen-ios.git @ relax-ticket-number-rule to https://github.com/Adyen/adyen-ios.git @ develop


Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

Copy link

sonarcloud bot commented Nov 1, 2024

@atmamont atmamont merged commit d77ce3c into develop Nov 1, 2024
15 of 16 checks passed
@atmamont atmamont deleted the relax-ticket-number-rule branch November 1, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a pull request that has chore changes that shouldn't be in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants