Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTHN-2322: Secure checkout on auth cancellation we reset & authentication release 3.1.0 #1891

Merged
merged 2 commits into from
Nov 14, 2024
Merged

AUTHN-2322: Secure checkout on auth cancellation we reset & authentication release 3.1.0 #1891

merged 2 commits into from
Nov 14, 2024

Conversation

robertdalmeida
Copy link
Contributor

@robertdalmeida robertdalmeida commented Nov 5, 2024 •
edited
Loading

Summary

  • Authentication SDK version 3.1.0 release
  • When user cancels authentication twice in a row we reset the credentials.
  • Update translations from smartling

Release notes

Updated Authentication SDK to 3.1.0 with updated configuration for secure checkout passkeys.

Ticket

AUTHN-2322

@robertdalmeida robertdalmeida self-assigned this Nov 5, 2024
github-actions[bot]
github-actions bot requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@robertdalmeida robertdalmeida force-pushed the AUTHN-2322-passkey-cancellation-deletion branch from 44884a0 to 9ccb4e8 Compare November 5, 2024 11:42
@robertdalmeida robertdalmeida added the new a pull request that adds a new feature label Nov 5, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 5, 2024
View reviewed changes
@goergisn goergisn changed the base branch from develop to AUTHN-2322-passkey-unstable-state November 8, 2024 13:33
@goergisn goergisn changed the base branch from AUTHN-2322-passkey-unstable-state to develop November 8, 2024 13:34
@goergisn goergisn dismissed github-actions[bot]’s stale review November 8, 2024 13:34

The base branch was changed.

github-actions[bot]
github-actions bot previously approved these changes Nov 8, 2024
View reviewed changes
@robertdalmeida robertdalmeida force-pushed the AUTHN-2322-passkey-cancellation-deletion branch from 57e4ab2 to 980492f Compare November 12, 2024 08:51
github-actions[bot]
github-actions bot previously approved these changes Nov 12, 2024
View reviewed changes
@robertdalmeida robertdalmeida marked this pull request as ready for review November 12, 2024 08:55
@robertdalmeida robertdalmeida changed the title AUTHN-2322: Delegated authentication on auth cancellation we reset & authentication release AUTHN-2322: Secure checkout on auth cancellation we reset & authentication release Nov 12, 2024
@robertdalmeida robertdalmeida changed the title AUTHN-2322: Secure checkout on auth cancellation we reset & authentication release AUTHN-2322: Secure checkout on auth cancellation we reset & authentication release 3.1.0 Nov 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 13, 2024
View reviewed changes
atmamont
atmamont reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@atmamont atmamont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would always split dependency update from any logic changes, would it be a hassle to split this into two PRs?

@robertdalmeida
Copy link
Contributor Author

robertdalmeida commented Nov 13, 2024 •
edited
Loading

I would always split dependency update from any logic changes, would it be a hassle to split this into two PRs?

@atmamont #1894
There was the bots MR that was for the dependency update, it missed a few things that we fixed in this MR. (I don't know how to fix the bot though). Let me know how you want to proceed.

@atmamont
Copy link
Contributor

I would always split dependency update from any logic changes, would it be a hassle to split this into two PRs?

@atmamont #1894 There was the bots MR that was for the dependency update, it missed a few things that we fixed in this MR. (I don't know how to fix the bot though). Let me know how you want to proceed.

Totally forgot that, Robert. Sorry, then let's not make this big.

atmamont
atmamont previously approved these changes Nov 13, 2024
View reviewed changes
goergisn
goergisn previously approved these changes Nov 13, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 13, 2024
View reviewed changes
erenbesel
erenbesel previously approved these changes Nov 13, 2024
View reviewed changes
@robertdalmeida robertdalmeida force-pushed the AUTHN-2322-passkey-cancellation-deletion branch from f963f67 to 0772e36 Compare November 13, 2024 12:03
@robertdalmeida robertdalmeida force-pushed the AUTHN-2322-passkey-cancellation-deletion branch from 0772e36 to 4286d8b Compare November 13, 2024 12:05
@goergisn goergisn self-requested a review November 13, 2024 12:15
@github-actions GitHub Actions
Copy link
Contributor

✅ No changes detected

Comparing https://github.com/Adyen/adyen-ios.git @ AUTHN-2322-passkey-cancellation-deletion to https://github.com/Adyen/adyen-ios.git @ develop

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robertdalmeida robertdalmeida merged commit 02e8899 into develop Nov 14, 2024
13 checks passed
@robertdalmeida robertdalmeida deleted the AUTHN-2322-passkey-cancellation-deletion branch November 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@erenbesel erenbesel erenbesel approved these changes

@goergisn goergisn goergisn approved these changes

@atmamont atmamont atmamont left review comments

@nauaros nauaros Awaiting requested review from nauaros

@neelSharma12 neelSharma12 Awaiting requested review from neelSharma12

Assignees

@robertdalmeida robertdalmeida

Labels
new a pull request that adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertdalmeida @atmamont @goergisn @erenbesel