Update CI workflows #1948
Open
Update CI workflows #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nauaros
added
the
chore
atmamont
reviewed
Jan 16, 2025
| @@ -10,20 +10,45 @@ on: | |||
| jobs: | |||
|
|
|||
| tests: | |||
| runs-on: macos-12 | |||
| runs-on: macos-14-xlarge | |||
There was a problem hiding this comment.
Do we need xlarge machine? We could use macos-latest and ideally forget about this type of updates.
atmamont
reviewed
Jan 16, 2025
.github/workflows/build.yml
Outdated
| xcode_version: '16.1' | ||
| needs_custom_sim: false # Takes the shipped simulator that comes with Xcode 16 | ||
|
|
||
| # - destination: 'name=iPhone 11 Pro' |
atmamont
reviewed
Jan 16, 2025
| @@ -23,7 +26,7 @@ jobs: | |||
| - name: Select latest Xcode | |||
| uses: maxim-lobanov/setup-xcode@v1 | |||
| with: | |||
| xcode-version: latest-stable | |||
| xcode-version: '16.1' | |||
There was a problem hiding this comment.
Why do we need to lock it now?
There was a problem hiding this comment.
We want to sync it with our local machines (like with v5) so the tests are reproducible
atmamont
reviewed
Jan 16, 2025
| - uses: n1hility/cancel-previous-runs@v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Select latest Xcode | ||
| uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: latest-stable | ||
| xcode-version: '16.1' |
There was a problem hiding this comment.
This looks repetitive, I guess it could be extracted to the top level as env var
env:
xcode_version: '16.1'
and later used as
with:
xcode-version: ${{env.xcode_version}}
atmamont
reviewed
Jan 16, 2025
| @@ -125,7 +125,7 @@ cp "../Demo/Configuration.swift" Source/Configuration.swift | |||
| xcodegen generate | |||
|
|
|||
| echo_header "Run Tests" | |||
| xcodebuild build test -project $PROJECT_NAME.xcodeproj -scheme App -destination "name=iPhone 13" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | xcpretty && exit ${PIPESTATUS[0]} | |||
| xcodebuild build test -project $PROJECT_NAME.xcodeproj -scheme App -destination "name=iPhone 16" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | xcpretty && exit ${PIPESTATUS[0]} | |||
There was a problem hiding this comment.
I guess this is a good candidate for env var extraction as we will be updating this once in a while
atmamont
reviewed
Jan 16, 2025
| swift package update | ||
|
|
||
| swift package generate-xcodeproj | ||
| echo " |
There was a problem hiding this comment.
This file change is substantial and is not very clear, can you provide brief explanation what's happening in here?
# Summary - Switching to `Void?` for `AssociatedKey`s as described [here](https://github.com/atrick/swift-evolution/blob/diagnose-implicit-raw-bitwise/proposals/nnnn-implicit-raw-bitwise-conversion.md#workarounds-for-common-cases) - Removing superfluous `swiftlint:disable` # Ticket <ticket> COIOS-000 </ticket> Co-authored-by: Alex Guretzki <[email protected]>
…ersion' into update-ci-machine-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Demo
Update workflows machine version.
Ticket
COIOS-000