Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9247] Add the merchant reference check in the paymentDetails response handler #2655

Merged
merged 3 commits into from
Jul 15, 2024
Merged

[ECP-9247] Add the merchant reference check in the paymentDetails response handler #2655

merged 3 commits into from
Jul 15, 2024

Conversation

SushmitaThakur
Copy link
Contributor

@SushmitaThakur SushmitaThakur commented Jun 18, 2024 •
edited
Loading

Description
This PR adds the check for merchant reference in the response for the paymentDetails end point to make sure that the merchant reference matches the current order.

Tested scenarios

  1. Payment with Ideal and 3DS2 cards with headful
  2. PaymentDetails endpoint response for 3DS2 card on headless

Fixes

[ECP-9247] Move the merchant reference check to `handlePaymentDetails…
5c2be93 
…Response` so that the validation of merchant reference on current order is always applied
@SushmitaThakur SushmitaThakur requested a review from a team as a code owner June 18, 2024 21:50
candemiralp
candemiralp previously approved these changes Jun 19, 2024
View reviewed changes
@candemiralp candemiralp self-requested a review June 19, 2024 08:39
@SushmitaThakur SushmitaThakur changed the title [ECP-9247] Add the merchant reference check in the paymentDetails response to prevent replay attacks [ECP-9247] Add the merchant reference check in the paymentDetails response Jun 19, 2024
@SushmitaThakur SushmitaThakur changed the title [ECP-9247] Add the merchant reference check in the paymentDetails response [ECP-9247] Add the merchant reference check in the paymentDetails response handler Jun 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SushmitaThakur SushmitaThakur merged commit 2f2d124 into main Jul 15, 2024
13 of 14 checks passed
@SushmitaThakur SushmitaThakur deleted the ECP-9247 branch July 15, 2024 10:44
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
Merged
@dimitriBouteille dimitriBouteille mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RokPopov RokPopov RokPopov approved these changes

@candemiralp candemiralp candemiralp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SushmitaThakur @candemiralp @RokPopov