Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9525]Adding channel parameter to /paymentMethods API call #2798

Merged
merged 8 commits into from
Nov 12, 2024
Merged

[ECP-9525]Adding channel parameter to /paymentMethods API call #2798

merged 8 commits into from
Nov 12, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

Description

channel parameter is being used to determine the type of the device or integration. Including this parameter in /paymentMethods call will help plugin to fetch the correct payment methods for headless implementation.
Eg. No ApplePay PaymentMethod for the Android devices.

Tested scenarios

Graphql and REST calls with channel parameter being passed in the query parameter

Fixes

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner November 6, 2024 14:51
@khushboo-singhvi khushboo-singhvi changed the title Adding channel parameter to /paymentMethods API call [ECP-9525]Adding channel parameter to /paymentMethods API call Nov 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khushboo-singhvi khushboo-singhvi merged commit 71972b8 into main Nov 12, 2024
13 of 14 checks passed
@khushboo-singhvi khushboo-singhvi deleted the ECP-9525 branch November 12, 2024 10:29
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Nov 12, 2024
Merged
@candemiralp candemiralp added the Feature Indicates a new feature addition label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SushmitaThakur SushmitaThakur SushmitaThakur approved these changes

@candemiralp candemiralp candemiralp approved these changes

Assignees
No one assigned
Labels
Feature Indicates a new feature addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushboo-singhvi @candemiralp @SushmitaThakur