Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9285] Fix Level 2 / Level 3 ESD additional data builder #2808

Merged
merged 7 commits into from
Nov 26, 2024
Merged

[ECP-9285] Fix Level 2 / Level 3 ESD additional data builder #2808

merged 7 commits into from
Nov 26, 2024

Conversation

candemiralp
Copy link
Member

@candemiralp candemiralp commented Nov 19, 2024 •
edited
Loading

Description

Request body for Level 2/3 Enhanced Scheme Data has been refactored with this PR.

  • Required fields have been revisited
  • Line item index has been moved to 1
  • Unit tests have been updated

For more information about Level 2/3 ESD, please visit Adyen Docs.

Tested scenarios

  • cardSchemeEnhancedDataLevel parameter has been obtained in the /payments API response

@candemiralp candemiralp marked this pull request as ready for review November 21, 2024 13:14
@candemiralp candemiralp requested a review from a team as a code owner November 21, 2024 13:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@candemiralp candemiralp added the Fix Indicates a bug fix label Nov 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 26, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@candemiralp candemiralp merged commit 6bfabbf into main Nov 26, 2024
12 of 14 checks passed
@candemiralp candemiralp deleted the ECP-9285 branch November 26, 2024 12:22
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SushmitaThakur SushmitaThakur SushmitaThakur approved these changes

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@candemiralp @khushboo-singhvi @SushmitaThakur