[ECP-9493] ApplePay and GooglePay -Terms & Conditions checkbox validation #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
changed the title
SushmitaThakur
previously approved these changes
Nov 19, 2024
peterojo
previously approved these changes
Nov 20, 2024
khushboo-singhvi
dismissed stale reviews from peterojo and SushmitaThakur
via
237b3d1
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
candemiralp
requested changes
Nov 25, 2024
view/frontend/web/js/view/payment/method-renderer/adyen-applepay-method.js
Outdated
Show resolved
Hide resolved
…ay-method.js Co-authored-by: Can Demiralp <[email protected]>
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
candemiralp
approved these changes
Nov 25, 2024
peterojo
approved these changes
Nov 25, 2024
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Merged
candemiralp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wallet payment methods such as ApplePay and GooglePay do not trigger the Terms and Conditions checkbox validation. When Terms and Conditions are enabled from Magento configuration, these wallet payment methods bypass the default form validation, as they mount their own "Place Order" buttons.
This PR solves the issue of Validating Terms & Conditions for ApplePay and GooglePay
Tested scenarios
Fixes