Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Maintenance #1182

Merged
merged 26 commits into from
Oct 10, 2024
Merged

E2E Maintenance #1182

merged 26 commits into from
Oct 10, 2024

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Oct 7, 2024 •
edited
Loading

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    E2E maintenance
  • What existing problem does this pull request solve?
    More stable tests

Tested scenarios

Description of tested scenarios:

  • quick flow

Fixed issue: SFI-967

@zenit2001 zenit2001 changed the title chore: enabling failing tests E2E Maintenance Oct 7, 2024
@zenit2001 zenit2001 added the excluded Will be ignored in the release notes label Oct 7, 2024
zenit2001 added 25 commits October 7, 2024 11:37
@zenit2001
fix: changing place order logic
82f57d0
@zenit2001
fix: changing selector for giftcards
fae4c4e
@zenit2001
fix: timeout added
91ae10a
@zenit2001
fix: changing submit payment
d37c019
@zenit2001
fix: changing waitForLoad with a timeout
14dc7f0
@zenit2001
fix: enabling paypal and cashapp
6c12117
@zenit2001
chore: enabling sepa in the pipeline
f71f852
@zenit2001
chore: changing paypal initiation
4334c0d
@zenit2001
chore: reverting paypal change
56b9bf6
@zenit2001
fix: ensuring visibility and adding a slight delay to paypal
a443eb4
@zenit2001
fix: adding some timeout to popup
3f32ba5
@zenit2001
fix: locator change
fcb3a2b
@zenit2001
fix: testing paypal click with a higher timeout time
435e0b9
@zenit2001
fix: adjusting global timeout to see output
2248f61
@zenit2001
chore: activating klarna tests
d7c84f5
@zenit2001
fix: adjusting submitPayment
2a8cf7c
@zenit2001
chore: enabling amazonpay, skipping sepa due to flakiness
d278eb5
@zenit2001
fix: adding a bit more timeout due to sandbox flakiness
34f5f11
@zenit2001
feat: updating playwright version
dcf6f57
@zenit2001
fix: changing workers and updating the expect timeout
03a2ad5
@zenit2001
fix: adjusting/removing some timeouts
5d9ebff
@zenit2001
fix: removing some more unnecessary timeouts
a53a8e1
@zenit2001
fix: changing popup logic
39d67e3
@zenit2001
chore: linting and changing timeout location
b510c39
@zenit2001
chore: moving back waitForTimeout
f18e84f
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
28.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@zenit2001 zenit2001 marked this pull request as ready for review October 9, 2024 07:26
@zenit2001 zenit2001 merged commit 8017d91 into develop Oct 10, 2024
17 of 18 checks passed
@zenit2001 zenit2001 deleted the improvement/SFI-967-e2e-maintenance branch October 10, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanikantsingh shanikantsingh shanikantsingh approved these changes

@amihajlovski amihajlovski amihajlovski approved these changes

@dcardos dcardos Awaiting requested review from dcardos

@shubhamk67 shubhamk67 Awaiting requested review from shubhamk67 shubhamk67 is a code owner

@ShubhamVijaivargiya ShubhamVijaivargiya Awaiting requested review from ShubhamVijaivargiya ShubhamVijaivargiya is a code owner

Assignees
No one assigned
Labels
excluded Will be ignored in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenit2001 @amihajlovski @shanikantsingh