Feature/adyen error objects #1228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanikantsingh
requested review from
amihajlovski,
shubhamk67,
ShubhamVijaivargiya and
zenit2001
as code owners
shanikantsingh
changed the base branch from
develop
to
feature/SFI-959-reliability-tracking
zenit2001
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Looks good, but we would need to consider the points below also, to ensure consistency:
- None of adyenDeleteRecurringPayment and deletePayment has a try/catch logic in them, meaning that if an error is thrown during deleting a stored payment method, we will not get any insight. I think we should apply the logic there also.
- zeroAuthPayment is inside a try catch , however it’s a helper function being used by savePayment(). Should we move try/catch logic in savePayment() instead?
- Should we consider adding an AdyenError in updateSavedCards()?
- Should we consider adding try/catch to notify() and remove try/catch on helper functions related to that. Instead we can replace them with AdyenError?
- Same as the above applies to begin.js file, removing the try/catch from the helpers and adding it to the main function.
| throw new Error('No Customer ID or RecurringDetailReference provided'); | ||
| } | ||
| if (!(customerID && recurringDetailReference)) { | ||
| throw new Error('No Customer ID or RecurringDetailReference provided'); |
There was a problem hiding this comment.
Should this one be also AdyenError?
| @@ -26,12 +26,14 @@ const AdyenHelper = require('*/cartridge/adyen/utils/adyenHelper'); | |||
| const AdyenConfigs = require('*/cartridge/adyen/utils/adyenConfigs'); | |||
| const constants = require('*/cartridge/adyen/config/constants'); | |||
| const AdyenLogs = require('*/cartridge/adyen/logs/adyenCustomLogs'); | |||
| const setErrorType = require('*/cartridge/adyen/logs/setErrorType'); | |||
| const { AdyenError } = require('*/cartridge/adyen/logs/adyenError'); | |||
|
|
|||
| // eslint-disable-next-line complexity | |||
| function donate(donationReference, donationAmount, orderToken) { | |||
| try { | |||
There was a problem hiding this comment.
Should we remove try/catch here, considering we are adding it at main function donation()?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Tested scenarios
Description of tested scenarios:
Fixed issue: #SFI-1007 #SFI-1025