Apple Pay on PDP #1237
Merged
Apple Pay on PDP #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product
* fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product
* feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: adding csrf validation to applePayExpressCommon.js and linting * chore: linting --------- Co-authored-by: Zenit Shkreli <[email protected]>
* feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: lint * chore: fix lint errors * fix: lint * chore: added tests for onshipping contact callback --------- Co-authored-by: shani <[email protected]>
* feat: update the UI for enabling express buttons * feat: make title bolder * feat: adapt adyen settings page for modern UI
amihajlovski
requested review from
shanikantsingh,
shubhamk67,
ShubhamVijaivargiya and
zenit2001
as code owners
|
zenit2001
approved these changes
Jan 17, 2025
shanikantsingh
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Make express payments from product details page
Offering new payment flow
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-397