Skip to content

Commit

Permalink
Bumping sf version to 4.8.0 (#2488)
Browse files Browse the repository at this point in the history
* Bumping sf version to 4.8.0

* Adding changeset file
  • Loading branch information
sponglord authored Dec 11, 2023
1 parent 92a832d commit b21c0f2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/light-pianos-join.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@adyen/adyen-web': minor
---

Bumping sf version to 4.8.0 which includes a more comprehensive startup log (to help with debugging)
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test('#1 avsCard error fields and inputs should have correct aria attributes', a
await t.switchToMainWindow().switchToIframe(cardPage.iframeSelector.nth(0));
const adb = await getInputSelector('encryptedCardNumber', true).getAttribute('aria-describedby');
await t.expect(adb).contains('adyen-checkout-encryptedCardNumber-');
await t.expect(adb).contains('-ariaError');
await t.expect(adb).contains('-ariaContext');
await t.switchToMainWindow();

// Address input's error field should have correct aria attrs
Expand Down
3 changes: 2 additions & 1 deletion packages/e2e/tests/utils/commonUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const getInputSelector = (fieldType, withSelector = false) => {
};

export const getAriaErrorField = (fieldType, withSelector = false) => {
const selStr = `#${fieldType}-ariaError`;
const selStr = `#${fieldType}-ariaContext`;
return withSelector ? Selector(selStr) : selStr;
};

Expand Down Expand Up @@ -68,6 +68,7 @@ export const deleteDigitsFromIFrame = async (t, iframeSelector, iFrameNum, iFram
};

export const checkIframeInputContainsValue = async (t, iframeSelector, iFrameNum, iFrameInputSelector, valueToCheck) => {
// prettier-ignore
return t
.switchToMainWindow()
.switchToIframe(iframeSelector.nth(iFrameNum))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const ENCRYPTED_SECURITY_CODE_4_DIGITS = 'encryptedSecurityCode4digits';

export const GIFT_CARD = 'giftcard';

export const SF_VERSION = '4.5.1';
export const SF_VERSION = '4.8.0';

export const DEFAULT_CARD_GROUP_TYPES = ['amex', 'mc', 'visa'];

Expand Down

0 comments on commit b21c0f2

Please sign in to comment.