Send error events for redirect errors #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longyulongyu
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
🦋 Changeset detectedLatest commit: 66856c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Size Change: +603 B (+0.08%) Total Size: 768 kB
ℹ️ View Unchanged
|
longyulongyu
force-pushed
the
Error-events-Redirect
branch
from
0266d5c to
78080a9
Compare
longyulongyu
force-pushed
the
Error-events-Redirect
branch
from
78080a9 to
6b7c6ae
Compare
ribeiroguilherme
approved these changes
Dec 4, 2024
| @@ -49,14 +51,17 @@ class RedirectShopper extends Component<RedirectShopperProps> { | |||
| }) | |||
| ); | |||
|
|
|||
| dispatchEvent.then(doRedirect).catch(() => {}); | |||
| dispatchEvent.then(doRedirect).catch(() => { | |||
| this.props.onRedirectError(); | |||
There was a problem hiding this comment.
Can you recall me in which scenarios does the Redirect may fail?
There was a problem hiding this comment.
To be honest, I cannot think of that many situations except for beforeRedirect callback gets rejected. doRedirect looks reliable to me, except for the onActionHandled callback from the merchant's side throws an error.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doRedirectthrows an errorTested scenarios
doRedirectFixed issue: COWEB-1463