Klarna - Fix for handling multiple instances of the widget #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4198784 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Size Change: +836 B (+0.11%) Total Size: 769 kB
ℹ️ View Unchanged
|
|
The approach is great, but, as it stands, without the changes to (I realise the change to the |
sponglord
reviewed
Dec 5, 2024
packages/lib/src/components/Klarna/components/KlarnaContainer/KlarnaContainer.tsx
Show resolved
Hide resolved
ribeiroguilherme
changed the title
ribeiroguilherme
requested review from
marcperez,
pabloai,
m1aw and
longyulongyu
as code owners
|
sponglord
approved these changes
Dec 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR to handle the issue with multiple instances of the Klarna widget being present in the PM list
There are 2 issues:
KlarnaWidgetit loads the KlarnaSDK, which in turn calls the callback we create (window.klarnaAsyncCallback), which initialises the KlarnaSDK.KlarnaWidgetin the PM list, initialising that will not see the KlarnaSDK calling our callback for a second time, and so the KlarnaSDK is not re-initialised with the rightsdkData.client_tokento make the correct payment.sdkData.client_tokenSo..
KlarnaWidgetcomponent it checks if it "manually" needs to initialise the KlarnaSDK widget (fixes issue 1)UIElementto allow it to run some custom logic (onPaymentMethodActive).This allows the
KlarnaWidgetto "manually" re-initialise the KlarnaSDK. (fixes issue 2)Proposed changes:
component.activate()which can be used when the Component is active.submit(), .mount(), etc)component.activate()is called in case the Component was previously createdKlarnaConfigurationFixes issue: COWEB-1468