Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Validation #113

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jdebecdelievre
Copy link

@jdebecdelievre jdebecdelievre commented Jun 5, 2018

PyFME passed the 2 following validation tests:

  • for small perturbations is gives the same answer as what is predicted by the analytical analysis of a linear system (as done in Etin & Reid, Dynamics of Flight)
  • for all control inputs and initial conditions I have attempted, it gives the same think as a Matlab Simulink model in which the equations of motion are preimplemented in the "6DOF" block of the Matlab aerospace blockset.
    I did all these tests on a simplified version of the Cessna 172 model (to make it easier to port to Matlab).

I created a "validation folder" containing two notebooks showing these validations steps.
I don't really know how to post the Matlab part of this (it is a simulink block diagram) so for now nothing is posted.

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #113 into master will decrease coverage by 9.2%.
The diff coverage is 21.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   93.07%   83.87%   -9.21%     
==========================================
  Files          43       44       +1     
  Lines        2254     2574     +320     
==========================================
+ Hits         2098     2159      +61     
- Misses        156      415     +259
Impacted Files Coverage Δ
src/pyfme/aircrafts/__init__.py 100% <100%> (ø) ⬆️
src/pyfme/utils/anemometry.py 93.54% <100%> (ø) ⬆️
src/pyfme/aircrafts/cessna_172.py 64.06% <13.2%> (-35.94%) ⬇️
src/pyfme/models/euler_flat_earth.py 45.5% <16.37%> (-54.5%) ⬇️
src/pyfme/models/state/aircraft_state.py 55.1% <20%> (-36.57%) ⬇️
src/pyfme/models/state/angular_velocity.py 70.58% <33.33%> (-7.99%) ⬇️
src/pyfme/models/state/velocity.py 75.92% <33.33%> (-8.52%) ⬇️
src/pyfme/models/state/acceleration.py 67.85% <33.33%> (-6.62%) ⬇️
src/pyfme/models/state/position.py 68.91% <33.33%> (-4.93%) ⬇️
src/pyfme/models/state/attitude.py 68.51% <33.33%> (-7.04%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db205fe...9c48167. Read the comment docs.

@AlexS12
Copy link
Member

AlexS12 commented Jul 16, 2018

Sorry for my late answer. Thanks for the PR!

This seems pretty impressive and I am really excited about this validation working. I will have a detailed look at it this week and see how to include this validations.

@AlexS12 AlexS12 mentioned this pull request Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants