-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed : Site A Button | Sit A button Image change | Spawn Slider | Site A button Accessible | Issue 3 & 2 & 5 & 4 #12
Fixed : Site A Button | Sit A button Image change | Spawn Slider | Site A button Accessible | Issue 3 & 2 & 5 & 4 #12
Conversation
The 2nd Slider in Slider Spawn was not working because the index of 2nd Slider was 2 which was supposed to be 1. Therefore I have changed the Index of 2nd Slider from 2 to 1. |
…isabled parameter which was set as true by dafault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the Issue 2, i have added the "if splash_bg_after.opacity == 1 else False" in the disabled parameter which was only set as true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Issue 5, the button_id for the button 5 was set as 4 which I changed to 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is for the Issue 4, I have changed the source of the Image file from off.png to on.png in the if else statement
I have added the commit for Issue 3,2,5,4 in one single PR. Please look into it. |
Pull Request Template
Proposed Changes
Describe the changes you've made.
For the Issue 3, I have changed the Index of 2nd Slider from 2 to 1.
For the Issue 2, i have added the "if splash_bg_after.opacity == 1 else False" in the disabled parameter which was only set as true.
For the Issue 5, the button_id for the button 5 was set as 4 which I changed to 5
For the Issue 4, I have changed the source of the Image file from off.png to on.png in the if else statement
Related Issues
Checklist