Merge pull request #98 from AgencyPMG/empty_recieve

Change Span Names When No Message is Handled
AgencyPMG · Jul 23, 2024 · e121aaa · e121aaa
2 parents 7fa8fd9 + 09c28b7
commit e121aaa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Otel/PmgQueueInstrumentation.php b/src/Otel/PmgQueueInstrumentation.php
@@ -112,6 +112,8 @@ public static function register(): bool
                     $span->setStatus(StatusCode::STATUS_ERROR, $exception->getMessage());
                 } elseif ($result === false) {
                     $span->setStatus(StatusCode::STATUS_ERROR, 'Message was not handled successfully');
+                } elseif ($result === null) {
+                    $span->updateName($queueName.' empty-receive');
                 }
 
                 $span->end();

diff --git a/test/integration/ConsumerOtelIntTest.php b/test/integration/ConsumerOtelIntTest.php
@@ -43,7 +43,7 @@ public function testConsumerOnceEmitsSpansWhenNoMessagesAreHandled() : void
         $this->assertFalse($called);
         $this->assertCount(1, $this->spans);
         $span = $this->spans[0];
-        $this->assertSame(self::Q.' receive', $span->getName());
+        $this->assertSame(self::Q.' empty-receive', $span->getName());
         $attr = $span->getAttributes();
         $this->assertSame(self::Q, $attr->get(TraceAttributes::MESSAGING_DESTINATION_NAME));
         $this->assertSame('receive', $attr->get(PmgQueueInstrumentation::OPERATION_TYPE));