(frontend)[Vault Hot Fix]: Stale secret state causing 404 when adding secrets after deletion #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jp-agenta
approved these changes
Dec 27, 2024
aybruhm
deleted the
hot-fix/-stale-secret-state-causing-404-when-adding-secrets-after-deletion
branch
aybruhm
added a commit
that referenced
this pull request
Feb 13, 2025
…ausing-404-when-adding-secrets-after-deletion (frontend)[Vault Hot Fix]: Stale secret state causing 404 when adding secrets after deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you delete a secret, and try to create/add a new one, the request fails with a 404. But when you reload the page, and try to create/add a new one, it works. I think that in the first instance, the state saves the deleted secret id which results to a 404.