[Feature] new playground hard-trimmed #2400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe, remove entrypoint, etc.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mmabrouk
reviewed
Jan 4, 2025
| data = str(data) | ||
|
|
||
| return data | ||
|
|
||
| async def fetch_inline_trace( |
There was a problem hiding this comment.
I copied the changes to this code, but not sure I understand everything
mmabrouk
reviewed
Jan 4, 2025
| not ag.tracing.is_inline_trace_ready(trace_id) | ||
| and remaining_steps > 0 | ||
| ): | ||
| await sleep(TIMESTEP) |
mmabrouk
reviewed
Jan 4, 2025
| if inline: | ||
| if WAIT_FOR_SPANS: |
There was a problem hiding this comment.
why did we set this to true per default
mmabrouk
reviewed
Jan 4, 2025
|
|
||
| await sleep(FINALSTEP) |
mmabrouk
reviewed
Jan 4, 2025
| content_type = "text/plain" | ||
| data = result | ||
| elif not isinstance(result, str) and content_type == "text/plain": | ||
| data = dumps(result) |
There was a problem hiding this comment.
so, it turns out that fastapi does this automatically, it stringifies the outputs and sets the content-type in the header to application/json in the case of non string output. Not sure whether we need this whole logic (old version and new version)
mmabrouk
reviewed
Jan 4, 2025
| wrapper=test_wrapper, | ||
| config_instance=config | ||
| ) | ||
| if request.state.config["references"]: |
There was a problem hiding this comment.
why are we doing this? removing all references other than application ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.