Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) Fix the issue with gh docker file working with ports different than 80 #2442

Merged
merged 12 commits into from
Feb 5, 2025
Merged

(docs) Fix the issue with gh docker file working with ports different than 80 #2442

merged 12 commits into from
Feb 5, 2025

Conversation

mmabrouk
Copy link
Member

This PR:

  • Fixes the GH Dockerfile that was using an outdated Node version, which caused buggy image builds
  • Adds functionality to use the GH Dockerfile with ports other than 80
  • Updates documentation and README with instructions for custom port configuration

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:38pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:38pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 30, 2025
@mmabrouk mmabrouk requested a review from jp-agenta January 30, 2025 16:45
@dosubot dosubot bot added bug Something isn't working documentation Improvements or additions to documentation labels Jan 30, 2025
@jp-agenta jp-agenta merged commit 1f9fee4 into dev Feb 5, 2025
7 of 11 checks passed
@aybruhm aybruhm deleted the build/make-docker-gh-work-with-build-for-fe branch February 5, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-agenta jp-agenta jp-agenta approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmabrouk @jp-agenta @aybruhm