Skip to content

Commit

Permalink
feat: allow getBundleIDFromInstallation to be called with a promise (#…
Browse files Browse the repository at this point in the history
…10304)

refs: #10256

## Description

While working on #10256, I noticed that `getBundleIDFromInstallation` is documented to take an Installation or a promise, it doesn't actually handle a promise. This changes the guard to resolve a promise before proceeding.

### Security Considerations

None

### Scaling Considerations

None

### Documentation Considerations

Make the code match the declaration

### Testing Considerations

I didn't.

### Upgrade Considerations

This makes the code slightly more liberal. It shouldn't break anything.
  • Loading branch information
mergify[bot] authored Jan 7, 2025
2 parents 9c97014 + 6f14a3e commit 0e4c5b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/zoe/src/typeGuards.js
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export const ZoeServiceI = M.interface('ZoeService', {
getInstallationForInstance: M.callWhen(M.await(InstanceHandleShape)).returns(
M.eref(M.remotable('Installation')),
),
getBundleIDFromInstallation: M.call(InstallationShape).returns(
getBundleIDFromInstallation: M.callWhen(M.await(InstallationShape)).returns(
M.eref(M.string()),
),

Expand Down

0 comments on commit 0e4c5b5

Please sign in to comment.