test(internal): clarify fake vstorage append

Agoric · Feb 7, 2025 · 418814c · 418814c
1 parent 83f9271
commit 418814c
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/packages/internal/src/storage-test-utils.js b/packages/internal/src/storage-test-utils.js
@@ -11,7 +11,7 @@ import { eventLoopIteration } from './testing-utils.js';
 
 /**
  * @import {TotalMap} from './types.js';
- * @import {Marshaller, StorageEntry, StorageMessage, StorageNode} from './lib-chainStorage.js';
+ * @import {Marshaller, StorageEntry, StorageMessage, StorageNode, StreamCell} from './lib-chainStorage.js';
  */
 
 const trace = makeTracer('StorTU', false);
@@ -174,8 +174,10 @@ export const makeFakeStorageKit = (rootPath, rootOptions) => {
           const newEntries = message.args;
           for (const [key, value] of newEntries) {
             value != null || Fail`attempt to append with no value`;
-            // In the absence of block boundaries, everything goes in a single StreamCell.
-            const oldVal = data.get(key);
+
+            /** @type {string | undefined} */
+            let oldVal = data.get(key);
+            /** @type {StreamCell | undefined} */
             let streamCell;
             if (oldVal != null) {
               try {
@@ -184,14 +186,20 @@ export const makeFakeStorageKit = (rootPath, rootOptions) => {
               } catch (_err) {
                 streamCell = undefined;
               }
+              // StreamCells reset at block boundaries.
+              if (
+                streamCell &&
+                Number(streamCell.blockHeight) !== currentBlockHeight
+              ) {
+                streamCell = undefined;
+                oldVal = undefined;
+              }
             }
-            if (
-              streamCell === undefined ||
-              Number(streamCell.blockHeight) !== currentBlockHeight
-            ) {
+
+            if (streamCell === undefined) {
               streamCell = {
                 blockHeight: String(currentBlockHeight),
-                values: !streamCell && oldVal != null ? [oldVal] : [],
+                values: oldVal != null ? [oldVal] : [],
               };
             }
             streamCell.values.push(value);