fix wallet extract-id CLI (#10892)

closes: #10891

## Description

A recent refactor of agoric-cli introduced an error. It wasn't caught by typecheck because the callsite was `any`. 

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations
none

### Testing Considerations
This PR doesn't have a runtime regression test because this is a very uncommon code path which does have _some_ CI coverage in a3p-integration (1d01880) 

### Upgrade Considerations
Not run on chain.

packages/agoric-cli/package.json

@@ -101,6 +101,6 @@
     "workerThreads": false
   },
   "typeCoverage": {
-    "atLeast": 78.19
+    "atLeast": 78.73
   }
 }

packages/agoric-cli/src/commands/wallet.js

@@ -55,6 +55,7 @@ export const makeWalletCommand = async command => {
     'wallet commands',
   );
 
+  /** @param {string} literalOrName */
   const normalizeAddress = literalOrName =>
     normalizeAddressWithOptions(literalOrName, wallet.opts());
 
@@ -112,9 +113,9 @@ export const makeWalletCommand = async command => {
     .action(async function (opts) {
       const offerStr = fs.readFileSync(opts.file).toString();
 
-      const { unserializer } = await makeVstorageKit({ fetch }, networkConfig);
+      const { marshaller } = makeVstorageKit({ fetch }, networkConfig);
 
-      const offerObj = unserializer.fromCapData(JSON.parse(offerStr));
+      const offerObj = marshaller.fromCapData(JSON.parse(offerStr));
       console.log(offerObj);
     });
 
@@ -127,9 +128,9 @@ export const makeWalletCommand = async command => {
     .action(async function (opts) {
       const offerStr = fs.readFileSync(opts.offer).toString();
 
-      const { unserializer } = await makeVstorageKit({ fetch }, networkConfig);
+      const { marshaller } = makeVstorageKit({ fetch }, networkConfig);
 
-      const offerObj = unserializer.fromCapData(JSON.parse(offerStr));
+      const offerObj = marshaller.fromCapData(JSON.parse(offerStr));
       console.log(offerObj.offer.id);
     });
 
@@ -204,7 +205,7 @@ export const makeWalletCommand = async command => {
     .command('list')
     .description('list all wallets in vstorage')
     .action(async function () {
-      const { vstorage } = await makeVstorageKit({ fetch }, networkConfig);
+      const { vstorage } = makeVstorageKit({ fetch }, networkConfig);
       const wallets = await vstorage.keys('published.wallet');
       process.stdout.write(wallets.join('\n'));
     });
@@ -218,17 +219,19 @@ export const makeWalletCommand = async command => {
       normalizeAddress,
     )
     .action(async function (opts) {
-      const { readPublished, unserializer, ...vsk } = makeVstorageKit(
-        { fetch },
-        networkConfig,
-      );
+      const {
+        readPublished,
+        marshaller: unserializer,
+        ...vsk
+      } = makeVstorageKit({ fetch }, networkConfig);
       const agoricNames = await makeAgoricNames(vsk.fromBoard, vsk.vstorage);
 
       const leader = makeLeader(networkConfig.rpcAddrs[0]);
       const follower = await makeFollower(
         `:published.wallet.${opts.from}`,
         leader,
         {
+          // @ts-expect-error xxx follower/marshaller types
           unserializer,
         },
       );

packages/agoric-cli/src/lib/chain.js

@@ -5,6 +5,7 @@ import { execFileSync as execFileSyncAmbient } from 'child_process';
 
 /**
  * @import {MinimalNetworkConfig} from '@agoric/client-utils';
+ * @import {ParamsSDKType} from '@agoric/cosmic-proto/agoric/swingset/swingset.js';
  */
 
 const agdBinary = 'agd';
@@ -132,6 +133,7 @@ harden(execSwingsetTransaction);
 /**
  *
  * @param {MinimalNetworkConfig} net
+ * @returns {ParamsSDKType}
  */
 // TODO fetch by HTTP instead of shelling out https://github.com/Agoric/agoric-sdk/issues/9200
 export const fetchSwingsetParams = net => {

packages/boot/package.json

@@ -95,6 +95,6 @@
     "workerThreads": false
   },
   "typeCoverage": {
-    "atLeast": 91.37
+    "atLeast": 91.27
   }
 }

packages/builders/package.json

@@ -81,6 +81,6 @@
     "workerThreads": false
   },
   "typeCoverage": {
-    "atLeast": 90.93
+    "atLeast": 91.57
   }
 }

packages/casting/package.json

@@ -59,6 +59,6 @@
     "workerThreads": false
   },
   "typeCoverage": {
-    "atLeast": 88.99
+    "atLeast": 89.22
   }
 }

packages/cosmic-swingset/package.json

@@ -69,6 +69,6 @@
     "timeout": "20m"
   },
   "typeCoverage": {
-    "atLeast": 83.84
+    "atLeast": 83.4
   }
 }

packages/governance/package.json

@@ -76,6 +76,6 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 89.49
+    "atLeast": 89.48
   }
 }

packages/inter-protocol/package.json

@@ -82,6 +82,6 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 95.58
+    "atLeast": 95.62
   }
 }

packages/internal/package.json

@@ -58,6 +58,6 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 93.06
+    "atLeast": 93.04
   }
 }

packages/orchestration/package.json

@@ -94,6 +94,6 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 97.29
+    "atLeast": 97.77
   }
 }

packages/store/package.json

@@ -59,6 +59,6 @@
     "timeout": "2m"
   },
   "typeCoverage": {
-    "atLeast": 89.53
+    "atLeast": 89.69
   }
 }

packages/swingset-liveslots/package.json

@@ -66,6 +66,6 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 75.24
+    "atLeast": 75.2
   }
 }

packages/vats/package.json

@@ -77,6 +77,6 @@
     "workerThreads": false
   },
   "typeCoverage": {
-    "atLeast": 91.21
+    "atLeast": 90.43
   }
 }

packages/xsnap-lockdown/package.json

@@ -44,6 +44,6 @@
     "workerThreads": false
   },
   "typeCoverage": {
-    "atLeast": 73.6
+    "atLeast": 73.54
   }
 }

packages/zoe/package.json

@@ -98,6 +98,6 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 85.06
+    "atLeast": 85.11
   }
 }