refactor(SwingSet): Improve config documentation, typing, and async function implementations #10538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
gibson-2024-11-swingset-types
branch
from
635e902 to
1275fae
Compare
Deploying agoric-sdk with
|
| Latest commit: |
0ac88bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://492b18e2.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-swingset-type.agoric-sdk.pages.dev |
gibson042
force-pushed
the
gibson-2024-11-swingset-types
branch
from
016ac5e to
c070769
Compare
siarhei-agoric
approved these changes
Feb 4, 2025
gibson042
force-pushed
the
gibson-2024-11-swingset-types
branch
from
c070769 to
0ac88bd
Compare
mhofman
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
defaultReapGCKrefsand vat-levelneverReap/reapGCKrefs, plus node-specificnodeOptions)name/metered/virtualObjectCacheSize)sourceSpec/bundleSpec/bundle, but the former additionally supportcreationOptions/parametersoptions while the latter do not)Security Considerations
None known.
Scaling Considerations
n/a
Documentation Considerations
None in particular.
Testing Considerations
n/a
Upgrade Considerations
n/a