Unbork Emerynet: Cleanup Auctioneers #10725 #10861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: #10725 Initial set of changes to get auctioneer governors terminated.
- contractGovernorExecutor: define ContractGovernorKit kind
- upgrade-governor-instance:
- fix SELF
- some docs
- rename to governorExecutorBundleId
- get .bundleID out of bundleRef
- move governor termination from self.shutdown to core eval
not via contract governor
refs: #10725 This change includes: * A single-file core-eval builder-proposal to terminate governed contracts and their governors by boardID. * A bootstrap test which: ** creates an instance of a simple governed contract via its own core-eval ** confirms that the contract accessible and operational ** kill the contract instance by boardID ** confirms that the contract is no longer operational
siarhei-agoric
changed the title
|
Uhh. Do you want a review at this point? Reviewers have been added, but it's marked Draft, and many parts look unfinished. |
siarhei-agoric
changed the base branch from
dev-upgrade-18
to
dev-upgrade-18-emerynet-fix
Deploying agoric-sdk with
|
| Latest commit: |
1964597
|
| Status: | 🚫 Build failed. |
refs: #10725
Chris-Hibbert
approved these changes
Jan 23, 2025
| @@ -78,4 +79,4 @@ | |||
| "typeCoverage": { | |||
| "atLeast": 89.49 | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Is json happy with files that don't end with a linefeed?
There was a problem hiding this comment.
Yes, but git and editor software definitely prefer its presence.
gibson042
requested changes
Jan 23, 2025
| @@ -0,0 +1,24 @@ | |||
| import { readFile } from 'node:fs/promises'; | |||
| import { fileURLToPath } from 'node:url'; | |||
| import { search } from '@endo/compartment-mapper'; | |||
There was a problem hiding this comment.
Make sure to add "@endo/compartment-mapper": "^1.4.0" to packages/internal/package.json dependencies.
Comment on lines
+42
to
+47
| if (!m) { | ||
| badTargets.push(arg); | ||
| } else { | ||
| // @ts-expect-error cast | ||
| targets.push(m.groups); | ||
| } |
There was a problem hiding this comment.
Indent-reduction suggestion:
Suggested change
| if (!m) { | |
| badTargets.push(arg); | |
| } else { | |
| // @ts-expect-error cast | |
| targets.push(m.groups); | |
| } | |
| if (!m) { | |
| badTargets.push(arg); | |
| continue; | |
| } | |
| // @ts-expect-error cast | |
| targets.push(m.groups); |
Comment on lines
+49
to
+53
| if (badTargets.length !== 0) { | ||
| throw makeError`malformed target(s): ${badTargets}`; | ||
| } else if (targets.length === 0) { | ||
| throw makeError`no target(s)`; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (badTargets.length !== 0) { | |
| throw makeError`malformed target(s): ${badTargets}`; | |
| } else if (targets.length === 0) { | |
| throw makeError`no target(s)`; | |
| } | |
| if (badTargets.length) throw makeError`malformed target(s): ${badTargets}`; | |
| if (!targets.length) throw makeError`no target(s)`; |
| @@ -41,7 +42,9 @@ const start = async (zcf, privateArgs) => { | |||
| getNum: () => params.getMalleableNumber(), | |||
| getApiCalled: () => governanceAPICalled, | |||
| }), | |||
| creatorFacet: makeGovernorFacet({}, { governanceApi }), | |||
| creatorFacet: makeFarGovernorFacet(Far('governedContract creatorFacet'), { | |||
There was a problem hiding this comment.
Opened #10879 to document the general problem that masked this bug until now.
Comment on lines
+65
to
+68
| // confirm the contract is no longer there | ||
| await t.throwsAsync(() => EV(publicFacet).getNum(), { | ||
| message: 'vat terminated', | ||
| }); |
There was a problem hiding this comment.
Can we also add something to prove that the governor has been terminated as well?
There was a problem hiding this comment.
The governor's public facet has getElectorate(), for example.
Co-authored-by: Richard Gibson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10725
Description
Create a single-file core-eval proposal-builder script to terminate a set of governed contracts passed as arguments as a list of boardID:label pairs.
Security Considerations
This can be [mis]used to kill any contract for which boardID is known.
Scaling Considerations
This script is intended to run as a core-eval, so there is no scaling issues for the script itself. However, it may take long time to process termination of some contracts with large state footprint.
Documentation Considerations
Not intended for wide use outside of Agoric eng.
Testing Considerations
Bootstrap test is included.
A3P testing had been considered but abandoned due to complications with retrieval of boardIDs for target contract instances.
Upgrade Considerations
This should run as part of next Emerynet upgrade.