Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(liveslots): enable ava worker threads #10874

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 22, 2025

closes: #9392
refs: #10848

Description

Enable ava workers for liveslots tests since there are some flakes on those tests as well, and we hope it might reduce them.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Keep an eye on test errors and flake alerts

Upgrade Considerations

None

@mhofman mhofman added the force:integration Force integration tests to run on PR label Jan 22, 2025
@mhofman mhofman requested a review from turadg January 22, 2025 19:31
@mhofman mhofman requested a review from a team as a code owner January 22, 2025 19:31
@mhofman mhofman added automerge:squash Automatically squash merge and removed force:integration Force integration tests to run on PR labels Jan 22, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b7a432
Status: ✅  Deploy successful!
Preview URL: https://bda667cc.agoric-sdk.pages.dev
Branch Preview URL: https://9392-worker-threads-liveslot.agoric-sdk.pages.dev

View logs

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised if this doesn't need the test changes in #10739

If it's green tho good to merge

@mergify mergify bot merged commit 8a7c1b2 into master Jan 22, 2025
83 checks passed
@mergify mergify bot deleted the 9392-worker-threads-liveslots branch January 22, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake in SwingSet gc test
2 participants