fix(swingset-xsnap-supervisor): Add missing promise-kit dependency #10878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
9d6dbc4
|
| Status: | 🚫 Build failed. |
mhofman
approved these changes
Jan 23, 2025
gibson042
approved these changes
Jan 23, 2025
kriskowal
force-pushed
the
kriskowal-fix-supervisor-missing-promise-kit
branch
from
90b2231 to
5791d6b
Compare
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
kriskowal
force-pushed
the
kriskowal-fix-supervisor-missing-promise-kit
branch
from
5791d6b to
9d6dbc4
Compare
mergify bot
added a commit
that referenced
this pull request
Jan 24, 2025
_incidental_ ## Description In #10878 I noticed, > This missing dependency should have been discovered by our linter, and it’s not clear how it was not. The package had disabled `import/no-extraneous-dependencies` for some reason. That was carried forward in the recent v9 upgrade: https://github.com/Agoric/agoric-sdk/pull/10846/files#diff-9ab4ae5d071b94a2d5dd874ceb3b9a1e85913fe7ee92e4956cb9801e59777002 This removes the special case and declares the deps so the rule passes. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI ### Upgrade Considerations none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toward better format preservation in Endo bundles, this change fixes a missing dependency in the XSnap SwingSet supervisor bundle that the current bundler tolerates and the upcoming bundler will not.
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
This missing dependency should have been discovered by our linter, and it’s not clear how it was not.
Upgrade Considerations
This change is safe, but implies certain risks for swapping out the internals of
nestedEvaluateandgetExportbundle generators since the new bundler is more sensitive, which is a breaking change. Landing changes like this make it less of a practically breaking change, but a risk none-the-less. We may need to ramp the major version of@endo/bundle-source.