chore: export @agoric/store types #10917
Conversation
packages/store/tsconfig.build.json
Outdated
| "../../tsconfig-build-options.json" | ||
| ], | ||
| "exclude": [ | ||
| // exported.d.ts already exists and it shouldn't be overwritten |
There was a problem hiding this comment.
Why is this necessary here and not in @agoric/zoe?
There was a problem hiding this comment.
https://github.com/Agoric/agoric-sdk/blob/master/packages/zoe/tsconfig.json doesn't include exported.js whereas https://github.com/Agoric/agoric-sdk/blob/master/packages/store/tsconfig.json does, so I need to exclude it. Another solution could be to remove it from tsconfig includes.
There was a problem hiding this comment.
Ah. I suppose it was in includes so it would be checked.
On balance, I think removing it from the includes is the better option because it's more consistent and suffices.
There was a problem hiding this comment.
Okey dokey :) 72b2080
packages/store/package.json
Outdated
| "lint:eslint": "eslint ." | ||
| "lint:eslint": "eslint .", | ||
| "prepack": "tsc --build tsconfig.build.json", | ||
| "postpack": "git clean -f ':!exported.d.ts' '*.d.ts*' '*.tsbuildinfo'" |
There was a problem hiding this comment.
please make this consistent as well:
| "postpack": "git clean -f ':!exported.d.ts' '*.d.ts*' '*.tsbuildinfo'" | |
| "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", |
There was a problem hiding this comment.
Ah, of course! Ready 5d590aa I've made everything one commit.
sirtimid
force-pushed
the
sirtimid/export-store-types
branch
from
72b2080 to
5d590aa
Compare
turadg
added
automerge:rebase
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
turadg
force-pushed
the
sirtimid/export-store-types
branch
from
5d590aa to
12d7e38
Compare
refs: #6343
Description
Properly expose TypeScript definitions from
@agoric/storepackage by adding TypeScript build steps inpackage.jsonwhich generate the definitions.Security Considerations
No security impact - only affects TypeScript type definitions which are stripped at compile time.
Scaling Considerations
No scaling impact - changes only affect development-time TypeScript support.
Documentation Considerations
No documentation updates needed - this is a developer-facing change for TypeScript users.
Testing Considerations
Existing type coverage tests continue to pass. No additional testing needed as this only affects type definition exposure.
Upgrade Considerations
No upgrade impact - purely development-time TypeScript support changes.