CCTP and Stride protos #10988
CCTP and Stride protos #10988
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
d3c8d99
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ebcbf5b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-protos.agoric-sdk.pages.dev |
| } | ||
|
|
||
| // Adds a new oracle | ||
| message MsgAddOracle { |
There was a problem hiding this comment.
I think these are the first app/chain-specific protos we're adding to this package. There seems to be a lot of non-user facing stuff in here. There's probably limited harm to including everything, but making sure it's a cognizant decision to do so.
A quick sweep it seems these are essential:
stakeibc,staketia,stakedymand their dependenciesrecords,epochs
These also seem to be user facing, but not needed for the .liquidStake story:
airdrop,autopilot,claim,vesting
If anything, maybe just remove icaoracle, interchainquery, mint (if it doesn't affect codegen via import deps)
There was a problem hiding this comment.
Only what ends up in the package exports will be used and I had only added stride/stakeibc/tx. But better not to include files that aren't exported. I'll keep it to staking packages (and deps) but I'll wait for @99adarsh to chime in before I merge.
There was a problem hiding this comment.
@turadg @0xpatrickdev keeping only stakeibc, staketia, stakedym and their dep makes sense.
|
Hey @turadg , I pulled the protos from stride's main branch. You can verify this from here https://github.com/Stride-Labs/stride/tree/main/proto/stride , Commit 41eb417 |
| @@ -96,6 +100,10 @@ | |||
| "types": "./dist/codegen/icq/v1/packet.d.ts", | |||
| "default": "./dist/codegen/icq/v1/packet.js" | |||
| }, | |||
| "./stride/stakeibc/tx.js": { | |||
There was a problem hiding this comment.
@turadg I think, we should also add stride/staketia/tx and stride/stakedym/tx as some of it will be used in the future.
turadg
force-pushed
the
ta/protos
branch
2 times, most recently
from
f62f840 to
d720009
Compare
- sourced from https://github.com/circlefin/noble-cctp/tree/38595d10898712dd03c848662be42cd038e25d56/proto - includes `yarn codegen` - mainly for `/circle.cctp.v1.MsgDepositForBurn`
Co-authored-by: 0xPatrick <[email protected]>
pulled rom stride's main branch, https://github.com/Stride-Labs/stride/tree/main/proto/stride , Commit 41eb417
Co-authored-by: 99adarsh <[email protected]>
|
Added bypass:integration because it was green on top of master yesterday and nothing here affects integration tests. |
incidental
Description
Adds CCTP and Stride message codecs to support upcoming work.
Stride protos pulled from master...99adarsh:agoric-sdk:stride-elys by @99adarsh
Security Considerations
no provenance info for Stride protos. @99adarsh can you explain how to confirm they're correct?
Scaling Considerations
This shouldn't affect other imports unless they use the barrel, and on-chain code doesn't.
Documentation Considerations
nothing special
Testing Considerations
mechanical, nothing to test
Upgrade Considerations
not on chain