Documentation for the CoreEval feature #799

Tyrosine22 · 2023-05-08T19:13:29Z

Here's the initial pass at CoreEval documentation.

BTW, some of the changes which originally appeared in this PR have been moved to the revisedgettingstarted PR (#811).

The gist with the output from the initial set of console commands is located here: https://gist.github.com/Tyrosine22/6da2367ae8897736953c2f1286164eed

The gist with the output from the final set of console commands is located here:
https://gist.github.com/Tyrosine22/12ba3222f15926f25eee30ce86be33f2

ivanlei

Can you please make requested changes and reply to questions.
How were the example shell commands tested? Can you add to the PR description a block of console output showing each example shell command being run and the successful output of them?

main/guides/coreeval/permissions.md

ivanlei · 2023-05-08T23:30:53Z

main/guides/coreeval/proposal.md

@@ -0,0 +1,59 @@
+# Code the Proposal
+
+You will need to write a proposal script that requests storageNode powers and passes them to the contract via privateArgs. For example, [here](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm.js) is the proposal we created for the PSM contract:


question:
The script below doesn't make use of storageNode. What is it meant to highlight or explain?

I rewrote the text blurbs at the top of both this page & the README.md page. Take a look at both, please.

main/guides/coreeval/permissions.md

ivanlei · 2023-05-08T23:34:06Z

main/guides/coreeval/permissions.md

@@ -0,0 +1,89 @@
+# Coding Permissions
+
+Write a json file with the permissions that the proposal will need. For example, [here](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm-permit.json) is the proposal Agoric created for the PSM contract:


comment:
The example is somewhat out of date with the code on master. Probably not a big deal.

I definitely think that's fine. The additional changes are contract-specific. However, one of the changes appears to be upgrade-related, so after I document the upgrade API, I want to return to this section, update the permissions page, and discuss the additional properties.

cloudflare-workers-and-pages · 2023-05-11T20:48:06Z

Deploying with Cloudflare Pages

Latest commit:	`eb90ae7`
Status:	✅ Deploy successful!
Preview URL:	https://393c6a1c.documentation-7tp.pages.dev
Branch Preview URL:	https://newcoreeval.documentation-7tp.pages.dev

View logs

main/guides/coreeval/permissions.md

michaelfig

Looking good so far! I have some suggestions, and will defer approval to another reviewer.

michaelfig · 2023-05-15T18:32:19Z

main/guides/coreeval/README.md

@@ -0,0 +1,12 @@
+# Injecting Code to Agoric Testnet
+
+Agoric facilitates safely injecting code to the Agoric testnet, usually for the purpose of running a contract and modifying it based on the result of a governance vote. To do so, we submit a proposal using cosmos-sdk level API ([swingset.CoreEval](https://community.agoric.com/t/blder-dao-governance-using-arbitrary-code-injection-swingset-coreeval/99)). The proposal runs a script that runs the contract, and possibly runs an additional script, depending on the result of a governance vote.


I took another stab at clarifying the last sentence, please consider with a grain of salt:

Suggested change

Agoric facilitates safely injecting code to the Agoric testnet, usually for the purpose of running a contract and modifying it based on the result of a governance vote. To do so, we submit a proposal using cosmos-sdk level API ([swingset.CoreEval](https://community.agoric.com/t/blder-dao-governance-using-arbitrary-code-injection-swingset-coreeval/99)). The proposal runs a script that runs the contract, and possibly runs an additional script, depending on the result of a governance vote.

Agoric facilitates safely injecting code to the Agoric testnet, usually for the purpose of running a contract and modifying it based on the result of a governance vote. To do so, we submit a proposal using cosmos-sdk level API ([swingset.CoreEval](https://community.agoric.com/t/blder-dao-governance-using-arbitrary-code-injection-swingset-coreeval/99)). If the proposal passes its governance vote, its JS code is run with ocaps extracted using the proposal's permit list, which the code can combine to perform privileged tasks.

The sentence has been changed to your suggestion.

michaelfig · 2023-05-15T18:37:08Z

main/guides/coreeval/permissions.md

+* **board**: Grants write access to the board name service. This permission is somewhat specific to the PSM contract.
+* **chainStorage**: Grants write access to the chain storage node, which is required when running `agd query` commands. Thus, most contracts will need access to this.
+* **zoe**: When this permission is set to "zoe", it grants access to the Zoe framework. All contracts will need access to this.
+* **feeMintAccess**: When this permission is set to "zoe", the contract will be able to create digital assets. Any contract that mints digital assets will need access to this.


Suggested change

* **feeMintAccess**: When this permission is set to "zoe", the contract will be able to create digital assets. Any contract that mints digital assets will need access to this.

* **feeMintAccess**: When this permission is set to "zoe", the contract will be able to create digital assets. Only contracts that mint privileged Agoric digital assets (not the unprivileged [`zcf.makeMint`](some link here)) will need access to this.

feeMintAccess's description has been changed to pretty much match your suggested text.

michaelfig · 2023-05-15T18:45:02Z

main/guides/coreeval/permissions.md

+* **bankManager**: Grants access to bank-related functionality within ERTP and Zoe. Most contracts will need access.
+* **board**: Grants write access to the board name service. This permission is somewhat specific to the PSM contract.
+* **chainStorage**: Grants write access to the chain storage node, which is required when running `agd query` commands. Thus, most contracts will need access to this.
+* **zoe**: When this permission is set to "zoe", it grants access to the Zoe framework. All contracts will need access to this.


It's probably worth mentioning above here that to "set" a permission, its value can be any truthy primitive. The value itself is not meaningful to the proposal (true, "zoe", "timer", "razzleflatz" and 249, are interchangeable and mean the same thing).

As a footnote, Agoric conventionally names its permission values for the identity of the home vat of the ocap corresponding to the permission. This can be useful for visualizing the produce/consume dependencies between actions.

Then, I'd change all the "permission is set to XXX" just to be "permission is set".

Suggested change

* **zoe**: When this permission is set to "zoe", it grants access to the Zoe framework. All contracts will need access to this.

* **zoe**: When this permission is set, it grants access to the Zoe framework. All contracts will need access to this.

An explanation was added to the top of the Permissions page saying that any string will set a permission. Similarly, all the permission descriptions were simplified per your suggestion above.

dckc · 2023-05-15T19:21:41Z

oops... I should have packaged up my comments into a reivew, I guess. But I thought I was just going to take a peek... then I saw 1 thing... then 1 more...

michaelfig · 2023-05-17T19:26:24Z

main/guides/coreeval/permissions.md

+Write a json file with the permissions that the proposal will need. For example,
+[gov-add-psm-permit.json](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm-permit.json) 
+is the proposal Agoric created for the PSM contract. Note that permissions are set by listing the
+permission and setting it to any String. Thus,`"bankManager": true` and `"bankManager": false` are


Suggested change

permission and setting it to any String. Thus,`"bankManager": true` and `"bankManager": false` are

permission and setting it to any truthy value. Thus,`"bankManager": true` and `"bankManager": 'hello'` are

Changed the text per your suggestion.

michaelfig · 2023-05-17T19:28:16Z

main/guides/coreeval/permissions.md

-* **zoe**: When this permission is set to "zoe", it grants access to the Zoe framework. All contracts will need access to this.
-* **feeMintAccess**: When this permission is set to "zoe", the contract will be able to create digital assets. Any contract that mints digital assets will need access to this.
+* **zoe**: When this permission is set, it grants access to the Zoe framework. All contracts will need access to this.
+* **feeMintAccess**: When this permission is set, the contract will be able to create digital assets. Only contracts that mint privileged Agoric digital assets (i.e., not the unprivileged **[zcf.makeZDFMint()](/reference/zoe-api/zoe-contract-facet.md#zcf-makezcfmint-keyword-assetkind-displayinfo)**) will need access to this.


Suggested change

* **feeMintAccess**: When this permission is set, the contract will be able to create digital assets. Only contracts that mint privileged Agoric digital assets (i.e., not the unprivileged **[zcf.makeZDFMint()](/reference/zoe-api/zoe-contract-facet.md#zcf-makezcfmint-keyword-assetkind-displayinfo)**) will need access to this.

* **feeMintAccess**: When this permission is set, the contract will be able to create digital assets. Only contracts that mint privileged Agoric digital assets (i.e., not the unprivileged **[zcf.makeZCFMint()](/reference/zoe-api/zoe-contract-facet.md#zcf-makezcfmint-keyword-assetkind-displayinfo)**) will need access to this.

Tyrosine22 · 2023-05-24T21:51:32Z

Can you please make requested changes and reply to questions.
How were the example shell commands tested? Can you add to the PR description a block of console output showing each example shell command being run and the successful output of them?

Here's the gist with the output: https://gist.github.com/Tyrosine22/6da2367ae8897736953c2f1286164eed

dckc

It's getting there, but there are still a number of corrections that are important.

dckc · 2023-05-25T02:10:37Z

main/guides/coreeval/local-testnet.md

+	make scenario2-run-chain
+	```
+5. Switch to another terminal and wait for the first block to be produced.
+6. Navigate to `<agoric-sdk>/bin` and start the client.


Suggested change

6. Navigate to `<agoric-sdk>/bin` and start the client.

6. Navigate to `<agoric-sdk>/bin` and submit the governance proposal.

It doesn't start a client running.

And this isn't part of starting a local chain; it shouldn't be under than heading.

I made the changes suggested above.

In addition, to address your second issue, (i.e., "it shouldn't be under that heading") I change the title of the topic to "Deploy a Governance Proposal to a Local Testnet" so that it properly reflects all the actions described in the topic.

I made the changes suggested above.

Did you push it yet? The most recent commit I see in this PR is on May 24 b22d2dd .

It's been pushed now.

dckc · 2023-05-25T02:21:22Z

main/guides/coreeval/proposal.md

+You will need to write a proposal script that runs the contract, and possibly does additional things depending on your needs. (Usually these additional things will be dependent on a governance vote.) For example, [gov-add-psm.js](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm.js) is a proposal Agoric created for the PSM contract:
+
+```jsx
+/* global startPSM */


The startPSM global was provided in the pismo boot configuration but isn't provided in vaults.

The global environment for CoreEval scripts is another thing we should document:

https://github.com/Agoric/agoric-sdk/blob/bf164a05f425460ad357841b537b8dbc044357a2/packages/vats/src/core/chain-behaviors.js#L78-L83

where farExports comes from import * as farExports from '@endo/far'; and hence includes E and Far.
endowments comes from a few lines previous:

https://github.com/Agoric/agoric-sdk/blob/bf164a05f425460ad357841b537b8dbc044357a2/packages/vats/src/core/chain-behaviors.js#L40-L45

Documenting VatData is a whole other thing; maybe we can leave that out of scope for now.

And allPowers.modules comes from:

https://github.com/Agoric/agoric-sdk/blob/bf164a05f425460ad357841b537b8dbc044357a2/packages/vats/src/core/boot-chain.js#L17-L20

startPSM was part of allPowers.modules in the pismo bootstrap. But in vaults, it's not there.

It sounds like you're saying that startPSM isn't a part of CoreEval's global environment anymore. But gov-add-psm.js is checked-in code, it appears to assume that startPSM is part of its global environment, and the code works when I run it. So it seems like startPSM is still in global?

gov-add-psm.js is checked-in code

yes, but there are no automated tests for it

the code works when I run it.

That surprises me. There are no errors in the agd logs? And you can see a new PSM contract started with agd query vstorage children published.psm.IST?

@michaelfig , @Tyrosine22 says you were there when it worked for him. Any idea how the global reference to startPSM worked? I'm confused.

Suggestion: just say "The script executes in an environment with globals such as E and Far provided." and leave enumeration of the whole list of globals to a later PR.

@michaelfig , @Tyrosine22 says you were there when it worked for him.

We verified that the vote passed and that something happened on the chain.

Any idea how the global reference to startPSM worked? I'm confused.

I don't know if the proposal contents were viable or completed successfully, only that they were initiated.

The following text was added to the top blurb on proposal.md:

"The script executes in an environment with globals such as E and Far provided."

dckc · 2023-05-25T02:22:33Z

main/guides/getting-started/README.md

@@ -43,12 +44,20 @@ The Agoric SDK is supported on <a href="https://en.wikipedia.org/wiki/Linux">Lin
 - To launch a terminal on Linux, use the **Terminal** application.
 - To access WSL from Windows, visit the [WSL documentation](https://docs.microsoft.com/en-us/windows/wsl/).

-## Install Node.js 16.19.1 or Higher
+## Install jQuery


Suggested change

## Install jQuery

## Install jq

jq is just jq. jQuery is https://jquery.com/

Fixed. (And moved to another PR)

dckc · 2023-05-25T02:27:25Z

main/guides/coreeval/local-testnet.md

+To create, start, and deploy an Agoric contract to a local Agoric Testnet, do the following:
+
+
+1. Install *Go* if needed.


Suggested change

1. Install *Go* if needed.

1. Install *Go* if needed. For example:

Installing go with brew assumes a mac with brew installed. Our platform section says we support linux, MacOS, and WSL.

Building the go stuff is something we left out of the SDK 'till now. It merits its own section. In Getting Started. The idea was that it wasn't needed for smart contract development. With the smart wallet architecture, this is no longer really viable.

p.s. the https://docs.agoric.com/guides/dapps/starting-multiuser-dapps.html looks like it discusses building the go stuff.

I've moved the installation of Go to the Getting Started section in another PR.

Also, I changed the installation instructions so they're platform agnostic. (I hadn't realized that "brew" was Mac-specific.)

dckc · 2023-05-25T02:29:02Z

main/guides/coreeval/local-testnet.md

+	```jsx
+	make scenario2-setup BASE_PORT=8000 NUM_SOLOS=0
+	```
+4. Start the chain.
+
+	```jsx
+	make scenario2-run-chain


can we use agoric start local-chain instead? I'd rather not promote the scenario2 stuff in the cosmic-swingset Makefile to a product feature.

We can, but let's do this in a separate PR; I was able to troubleshoot the "This project isn't in a folder created by agoric init" error, but I've run into a different error, and this one doesn't have a helpful error message. I'll ping you or mfig to work through it.

All the "make scenario2" commands have been converted to various "agoric XXX" commands.

main/guides/coreeval/permissions.md

main/guides/getting-started/README.md

main/guides/coreeval/local-testnet.md

dckc · 2023-05-30T14:57:57Z

main/guides/coreeval/README.md

@@ -0,0 +1,12 @@
+# Injecting Code to Agoric Testnet
+
+Agoric facilitates safely injecting code to the Agoric testnet, usually for the purpose of running a contract and modifying it based on the result of a governance vote. To do so, we submit a proposal using cosmos-sdk level API ([swingset.CoreEval](https://community.agoric.com/t/blder-dao-governance-using-arbitrary-code-injection-swingset-coreeval/99)). If the proposal passes its governance vote, its JavaScript code is run with ocaps extracted using the proposal's permit list, which the code can combine to perform privileged tasks.


the Agoric testnet? The term doesn't have a clear referent; it could be devnet or emerynet or ollinet... but what this PR seems to document is a local network.

Right... throughout this PR the reader is shown how to inject code into a local Testnet, but presumably they'd also be able to inject code into a remote Testnet.

dckc · 2023-05-30T15:01:42Z

main/guides/coreeval/permissions.md

+# Coding Permissions
+
+Write a json file with the permissions that the proposal will need. For example,


Above it's called a "permit list". Here it's called "permissions". Any particular reason for the difference?

My preference would be...

Suggested change

# Coding Permissions

Write a json file with the permissions that the proposal will need. For example,

# Declaring Required Capabilities

Write a json file declaring the capabilities that the proposal will need. For example,

No, there wasn't any real reason for the differences. They were just terms carried over from different sources. The terms should be standardized, but I wasn't sure which term best captures what's going on. I'm still not sure, actually.

I've changed the topic to largely conform to your "capabilities" language. The terms should be more standardized (permit list vs. permissions. vs capabilities), but (as I said above) I'm not 100% sure about which term I like best, and the topic reads OK as-is. So... it's good enough for now, I suppose.

dckc · 2023-05-30T15:04:37Z

main/guides/coreeval/permissions.md

+
+Write a json file with the permissions that the proposal will need. For example,
+[gov-add-psm-permit.json](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm-permit.json) 
+is the proposal Agoric created for the PSM contract. Note that permissions are set by listing the


"proposal" is yet another way to refer to it here. Suggestion:

Suggested change

is the proposal Agoric created for the PSM contract. Note that permissions are set by listing the

declares capabilities needed to start a new PSM contract. Note that capabilities are declared using their name as a property along with any truthy value.

The text has been changed to the suggested passage.

dckc · 2023-05-30T15:07:04Z

main/guides/coreeval/permissions.md

+```
+:::
+
+## Consume Section


There's more than one consume section: there's one at the top level and then one under issuer, one under brand etc.

Perhaps:

Suggested change

## Consume Section

## Top Level Section - Consume

Good point. The titles of the Top Level Consume & Top Level Produce sections have been changed to explicitly state that they're the top level.

main/guides/coreeval/permissions.md

dckc · 2023-06-13T23:54:02Z

main/guides/coreeval/permissions.md

+Note that any **Brands** associated with digital assets that the contract mints 
+are not included in this section, unless they're also produced or consumed in some other capacity.


I still don't understand why this "not included in this section" note is here. It seems wrong.

It was based on a misunderstanding I had of what the Brand & Issuer sections contained. I've deleted the note.

dckc

This conveys the gist of what folks need to know, so I'm approving.

I would prefer that we finish 2 things before landing this, but they can probably be addressed later (or maybe even never) without much harm: The note about brands not being included doesn't seem right to me. Nor does the startPSM global.

dckc

still looks good

dckc · 2023-06-19T22:33:21Z

main/guides/coreeval/local-testnet.md

-4. Switch to another terminal and wait for the first block to be produced.
-5. Navigate to `<agoric-sdk>/bin` and submit the governance proposal.
+
+5. Wait for the first block to be produced.


"How can I tell?" I can imagine our audience asking. I suggest providing an example log entry showing a block being produced.

(suggestion; not critical / important)

michaelfig · 2023-06-20T15:35:31Z

@ivanlei, have your requested changes been addressed?

ivanlei

🚀

Tyrosine22 added 4 commits May 8, 2023 11:59

Adding the new coreeval files

79db198

Adding the new coreeval files

f5ca122

Modifying the navigation files

3076b3a

Modifying the navigation files

b429cf0

Tyrosine22 requested a review from ivanlei May 8, 2023 19:13

Tyrosine22 changed the title ~~Newcoreeval~~ Documentation for the CoreEval feature May 8, 2023

ivanlei suggested changes May 8, 2023

View reviewed changes

Tyrosine22 added 2 commits May 11, 2023 13:47

Updated the navigation files with the new section title

41ea905

Responded to PR feedback

398d7e6

Tyrosine22 requested a review from ivanlei May 11, 2023 20:54

dckc reviewed May 15, 2023

View reviewed changes

main/guides/coreeval/permissions.md Outdated Show resolved Hide resolved

dckc reviewed May 15, 2023

View reviewed changes

main/guides/coreeval/permissions.md Outdated Show resolved Hide resolved

dckc reviewed May 15, 2023

View reviewed changes

main/guides/coreeval/permissions.md Outdated Show resolved Hide resolved

michaelfig reviewed May 15, 2023

View reviewed changes

Responding to PR feedback

647a07c

Tyrosine22 requested review from michaelfig and dckc May 17, 2023 16:44

michaelfig reviewed May 17, 2023

View reviewed changes

Tyrosine22 added 2 commits May 24, 2023 16:17

Responding to PR feedback

1d56b80

Responding to PR feedback

b22d2dd

dckc requested changes May 25, 2023

View reviewed changes

dckc reviewed May 25, 2023

View reviewed changes

main/guides/coreeval/local-testnet.md Outdated Show resolved Hide resolved

Tyrosine22 added 2 commits May 30, 2023 06:41

Responded to PR feedback

fe3040a

Moving the setup changes to their own PR

c09f748

dckc reviewed May 30, 2023

View reviewed changes

Tyrosine22 added 2 commits May 30, 2023 12:59

Responding to PR feedback

78aebad

Responding to PR feedback

e5492db

dckc reviewed Jun 13, 2023

View reviewed changes

dckc approved these changes Jun 14, 2023

View reviewed changes

dckc mentioned this pull request Jun 14, 2023

Revisedgettingstarted #811

Merged

Updating the console command

ef84da2

dckc approved these changes Jun 19, 2023

View reviewed changes

Tyrosine22 added 3 commits June 19, 2023 20:17

Responded to PR feedback

ca2b873

Responded to PR feedback

0a94fdd

Made a minor improvement to the instructions

0dbc077

michaelfig approved these changes Jun 20, 2023

View reviewed changes

ivanlei approved these changes Jun 20, 2023

View reviewed changes

Merge branch 'main' into newcoreeval

eb90ae7

Tyrosine22 merged commit 05c7693 into main Jun 20, 2023

Tyrosine22 deleted the newcoreeval branch June 20, 2023 19:29

dckc mentioned this pull request Jul 29, 2023

how to grant chainStorage access to a contract? #767

Closed

		@@ -0,0 +1,59 @@
		# Code the Proposal

		You will need to write a proposal script that requests storageNode powers and passes them to the contract via privateArgs. For example, [here](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm.js) is the proposal we created for the PSM contract:

		@@ -0,0 +1,89 @@
		# Coding Permissions

		Write a json file with the permissions that the proposal will need. For example, [here](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/test/psm/gov-add-psm-permit.json) is the proposal Agoric created for the PSM contract:

		@@ -0,0 +1,12 @@
		# Injecting Code to Agoric Testnet

		Agoric facilitates safely injecting code to the Agoric testnet, usually for the purpose of running a contract and modifying it based on the result of a governance vote. To do so, we submit a proposal using cosmos-sdk level API ([swingset.CoreEval](https://community.agoric.com/t/blder-dao-governance-using-arbitrary-code-injection-swingset-coreeval/99)). The proposal runs a script that runs the contract, and possibly runs an additional script, depending on the result of a governance vote.

	* feeMintAccess: When this permission is set to "zoe", the contract will be able to create digital assets. Any contract that mints digital assets will need access to this.
	* feeMintAccess: When this permission is set to "zoe", the contract will be able to create digital assets. Only contracts that mint privileged Agoric digital assets (not the unprivileged [`zcf.makeMint`](some link here)) will need access to this.

	* zoe: When this permission is set to "zoe", it grants access to the Zoe framework. All contracts will need access to this.
	* zoe: When this permission is set, it grants access to the Zoe framework. All contracts will need access to this.

	permission and setting it to any String. Thus,`"bankManager": true` and `"bankManager": false` are
	permission and setting it to any truthy value. Thus,`"bankManager": true` and `"bankManager": 'hello'` are

	6. Navigate to `<agoric-sdk>/bin` and start the client.
	6. Navigate to `<agoric-sdk>/bin` and submit the governance proposal.

		To create, start, and deploy an Agoric contract to a local Agoric Testnet, do the following:


		1. Install Go if needed.

	1. Install Go if needed.
	1. Install Go if needed. For example:

	is the proposal Agoric created for the PSM contract. Note that permissions are set by listing the
	declares capabilities needed to start a new PSM contract. Note that capabilities are declared using their name as a property along with any truthy value.

		Note that any Brands associated with digital assets that the contract mints
		are not included in this section, unless they're also produced or consumed in some other capacity.

Documentation for the CoreEval feature #799

Documentation for the CoreEval feature #799

Conversation

Tyrosine22 commented May 8, 2023 • edited Loading

ivanlei left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented May 11, 2023 • edited Loading

Deploying with Cloudflare Pages

michaelfig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc commented May 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tyrosine22 commented May 24, 2023

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tyrosine22 Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaelfig commented Jun 20, 2023

ivanlei left a comment

Choose a reason for hiding this comment

Tyrosine22 commented May 8, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented May 11, 2023 •

edited

Loading

Tyrosine22 Jun 13, 2023 •

edited

Loading