Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIDER-1977: Add a new argument litellm-extra-params #1998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mark-bradshaw
Copy link

Add a new config argument litellm-extra-params that takes a string of JSON that should be used as a global litellm config base. Values set in the model settings will override those in the global config.

Copy link
Contributor

@fry69 fry69 Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I meant with my "update" in the other comment:

If you do not have the LiteLLM repo installed alongside the aider repo (as a sibling folder, not inside the aider repo of course) you'll delete all these generated API key names.

@paul-gauthier This is an unmaintainable nightmare IMHO and should get fixed.

@mark-bradshaw
Copy link
Author

mark-bradshaw commented Oct 10, 2024 via email

@paul-gauthier
Copy link
Collaborator

Thanks for your interest in contributing to aider. It seems very unusual to have a command line parameter that accepts a json blob. I don't think we can adopt that approach. Unfortunately, I'm not sure I have a better suggestion yet though.

@mark-bradshaw
Copy link
Author

@paul-gauthier Well, my need is tied just to adding headers, so if it feels better I can tighten it down to a semicolon separated list of headers to add. Ex "header1=value1;header2=value2".

@mark-bradshaw
Copy link
Author

OK, here's another try. I switched to a semicolon separated list of header values. It's just a string, so no JSON parsing any more. Code is simpler too.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@mark-bradshaw
Copy link
Author

@paul-gauthier I rebased the code to trim it down and fix up the wrong name/email on commits. I also signed the CLA. Ready to go.

@mark-bradshaw
Copy link
Author

@paul-gauthier @fry69 Is there anything in the updated approach that you would like changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants