feat: add authorize operation metrics #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/metrics
branch
2 times, most recently
from
9077473 to
7e149b2
Compare
jeqo
commented
Oct 15, 2024
There was a problem hiding this comment.
Adding standard kafka metrics configurations (available in other modules using kafka-metrics).
| import org.apache.kafka.common.utils.Time; | ||
| import org.apache.kafka.server.authorizer.AuthorizationResult; | ||
|
|
||
| public class AivenAclAuthorizerMetrics { |
There was a problem hiding this comment.
Adding total/rate metrics for allowed/denied operations:
- Allowed tagged by operation to know e.g. which operation may be rising.
- Denied tagged by op/resource/principal to know e.g. which client is failing to authenticate to which resource.
Currently, the only way to troubleshoot denied operations is by going to the log. To make this easier, there are a couple of metrics being added: one for each result type. Allowed operations are tagged by operation, so the cardinality is bound to the type of operations. Denied operations are tagged further with resource and principal. Even though this increases the cardinality considerably, it should only be used for the cases where there are authorization issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to troubleshoot denied operations is by going to the log.
To make this easier, there are a couple of metrics being added: one for each result type.
Allowed operations are tagged by operation, so the cardinality is bound to the type of operations.
Denied operations are tagged further with resource and principal. Even though this increases the cardinality considerably, it should only be used for the cases where there are authorization issues.