Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add acl host matching #214

Merged
merged 1 commit into from
Nov 7, 2024
Merged

feat: add acl host matching #214

merged 1 commit into from
Nov 7, 2024

Conversation

biggusdonzus
Copy link
Contributor

@biggusdonzus biggusdonzus commented Nov 5, 2024 •
edited
Loading

Improve the Aiven ACL by adding the capability to match by host. The feature support literals matching or * for wildcard.

@biggusdonzus biggusdonzus force-pushed the fdorlandi-add-host-matcher branch 4 times, most recently from 4e72fa0 to e07a4d7 Compare November 5, 2024 16:38
@biggusdonzus biggusdonzus reopened this Nov 5, 2024
@biggusdonzus biggusdonzus marked this pull request as ready for review November 5, 2024 16:45
@biggusdonzus biggusdonzus requested review from a team as code owners November 5, 2024 16:45
tvainika
tvainika requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@tvainika tvainika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACL listing public method AivenAclAuthorizerV2::acls(...) is not properly tested for host field and does not return configured host field correctly.

Also documentation (README.md) is missing for host field.

src/main/java/io/aiven/kafka/auth/json/AivenAcl.java Outdated Show resolved Hide resolved
@biggusdonzus biggusdonzus force-pushed the fdorlandi-add-host-matcher branch from e07a4d7 to fb61940 Compare November 6, 2024 11:25
@tvainika tvainika merged commit 48cd186 into main Nov 7, 2024
4 checks passed
@tvainika tvainika deleted the fdorlandi-add-host-matcher branch November 7, 2024 08:30
@biggusdonzus biggusdonzus mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvainika tvainika tvainika approved these changes

@AnatolyPopov AnatolyPopov Awaiting requested review from AnatolyPopov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biggusdonzus @tvainika