fix: fixed various stuff that were blocking a new out of the box installation only using the GNUmakefile
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allation only using the `GNUmakefile` fixed errors that I've encountered by cloning the project from scratch in a new folder and using the `GNUmakefile` to set it up and running.
aiven-anton
reviewed
Nov 24, 2023
| cd requirements && pip-compile --upgrade --resolver=backtracking requirements.in | ||
| cd requirements && pip-compile --upgrade --resolver=backtracking requirements-dev.in | ||
| cd requirements && pip-compile --upgrade --resolver=backtracking requirements-typing.in | ||
| pip-compile --upgrade --resolver=backtracking requirements/requirements.in -o requirements/requirements.txt |
There was a problem hiding this comment.
Note: the reason this breaks is because the use of .ONESHELL:. That feature doesn't exist in the version of make that ships with macs, resulting in diverging behaviors.
Once we have a more complete docker dev env, I'll argue for removing much of the makefile targets that downloads executables and sets up venvs and so on.
aiven-anton
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed errors that I've encountered by cloning the project from scratch in a new folder and using the
GNUmakefileto set it up and running.