fix: create new schema and version on reference update #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When only updating a reference to a schema a new schema and version is required to be created. Closes #783
jjaakola-aiven
force-pushed
the
jjaakola-aiven-on-reference-update-create-new-schema-and-version
branch
from
2d10140 to
7174a7f
Compare
giuseppelillo
approved these changes
Dec 20, 2023
giuseppelillo
deleted the
jjaakola-aiven-on-reference-update-create-new-schema-and-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
When only updating a reference to a schema a new schema and version is required to be created.
The references are also included in the schema fingerprint.
References: #783
Closes #783
Why this way
The full protobuf schema requires also the the references. If reference is updated the schema is changed, the actual schema string may be the same. Th