Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to all GitHub Actions workflows #563

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/autofix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
fix-line-endings:
runs-on: ubuntu-latest
timeout-minutes: 1
steps:
# git-auto-commit-action is a bit tricky to use, see its README
- uses: actions/checkout@v3
Expand Down
25 changes: 15 additions & 10 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,25 @@ on:

jobs:
shellcheck:
timeout-minutes: 1
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: shellcheck --color=always --shell=bash --exclude=SC2086,SC2059,SC2046,SC2235,SC2002,SC2206,SC2068,SC2207,SC2013 *.sh activate

editorconfig-checker:
timeout-minutes: 1
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
# Hard-coded commit, because the latest changes aren't tagged.
- uses: editorconfig-checker/action-editorconfig-checker@d4fca16fc71adef10fbe101903b654449fa9570c
with:
version: 2.7.0
- run: editorconfig-checker

test:
timeout-minutes: 5
runs-on: ubuntu-22.04
strategy:
matrix:
Expand All @@ -35,6 +48,7 @@ jobs:

doctest:
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: sudo apt update
Expand All @@ -48,6 +62,7 @@ jobs:

compare-compilers:
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: sudo apt update
Expand All @@ -58,13 +73,3 @@ jobs:
- run: LLVM_CONFIG=llvm-config-13 ./compare_compilers.sh
- run: make clean
- run: LLVM_CONFIG=llvm-config-14 ./compare_compilers.sh

editorconfig-checker:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
# Hard-coded commit, because the latest changes aren't tagged.
- uses: editorconfig-checker/action-editorconfig-checker@d4fca16fc71adef10fbe101903b654449fa9570c
with:
version: 2.7.0
- run: editorconfig-checker
3 changes: 3 additions & 0 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
test:
runs-on: macos-latest
timeout-minutes: 5
strategy:
matrix:
# Testing all levels because there was a bug that only happened with -O1. (#224)
Expand Down Expand Up @@ -37,6 +38,7 @@ jobs:

doctest:
runs-on: macos-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: brew install bash diffutils llvm@{13,14}
Expand All @@ -47,6 +49,7 @@ jobs:

compare-compilers:
runs-on: macos-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: brew install bash diffutils llvm@{13,14}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/netbsd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 5
Akuli marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v4
- uses: cross-platform-actions/[email protected]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
jobs:
release:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: git fetch --tags
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/valgrind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
jobs:
valgrind:
runs-on: ubuntu-22.04
timeout-minutes: 60
strategy:
matrix:
llvm-version: [11, 13, 14]
Expand Down Expand Up @@ -44,6 +45,7 @@ jobs:
create-issue-on-failure:
name: Create an issue if valgrind failed
runs-on: ubuntu-latest
timeout-minutes: 5
needs: [valgrind]
#if: ${{ github.repository == 'Akuli/jou' && always() && github.event_name == 'schedule' && needs.valgrind.result == 'failure' }}
if: ${{ github.repository == 'Akuli/jou' && always() && needs.valgrind.result == 'failure' }}
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
# * I can be sure that I didn't accidentally include something unnecessary or do something else dumb.
check-small-mingw64:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
# Same URLs as in windows_setup.sh
- name: Download the small mingw64
Expand Down Expand Up @@ -66,6 +67,7 @@ jobs:

build-zip:
runs-on: windows-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
# TODO: figure out why --small doesn't work here
Expand Down Expand Up @@ -147,6 +149,7 @@ jobs:

test:
runs-on: windows-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -159,6 +162,7 @@ jobs:

doctest:
runs-on: windows-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: ./windows_setup.sh --small
Expand All @@ -169,6 +173,7 @@ jobs:
test-zip:
needs: build-zip
runs-on: windows-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -186,6 +191,7 @@ jobs:

compare-compilers:
runs-on: windows-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- run: source activate && ./windows_setup.sh --small
Expand Down
Loading