Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for LLVM versions older than 14 #614

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Drop support for LLVM versions older than 14 #614

merged 5 commits into from
Jan 14, 2025

Conversation

Akuli
Copy link
Owner

@Akuli Akuli commented Jan 14, 2025

Fixes #473

@Akuli
Copy link
Owner Author

Akuli commented Jan 14, 2025 •
edited
Loading

This PR ended up doing two things:

  • Refactor the compiler so that class Foo may contain pointers to instances of Foo
  • Drop support for LLVM versions older than 14

I'll split it up into two PRs. Or maybe I'll keep the support for older LLVMs...

@Akuli Akuli closed this Jan 14, 2025
@Akuli Akuli mentioned this pull request Jan 14, 2025
Closed
@Akuli Akuli reopened this Jan 14, 2025
@Akuli
Copy link
Owner Author

Akuli commented Jan 14, 2025

Reopening, because turns out that both changes are needed. This doesn't work on LLVM 11 and 13 (I tried in #615).

@Akuli Akuli merged commit d80aba7 into main Jan 14, 2025
54 checks passed
@Akuli Akuli deleted the llvm-drop branch January 14, 2025 13:18
@Akuli Akuli mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler segfault when struct contains array of pointers to itself
1 participant
@Akuli