Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'make clean' #719

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Fix 'make clean' #719

merged 3 commits into from
Feb 3, 2025

Conversation

Akuli
Copy link
Owner

@Akuli Akuli commented Feb 2, 2025

Currently folder paths in Makefile.* and bootstrap.sh are not the same like they should be, which causes make clean to print a lot of unnecessary output.

@Akuli
Copy link
Owner Author

Akuli commented Feb 3, 2025

Actually, I think make clean

  • shouldn't delete tmp/bootstrap_cache
  • should delete the jou_bootstrap executable

Currently, make clean doesn't delete jou_bootstrap, so running make again is pretty fast, but if the bootstrap script is changed, it will surprise you by rebootstrapping the whole thing.

@Akuli Akuli changed the title Fix file paths in 'make clean' Fix 'make clean' Feb 3, 2025
@Akuli Akuli merged commit 1b5a38a into main Feb 3, 2025
38 checks passed
@Akuli Akuli deleted the clean branch February 3, 2025 21:16
@Akuli Akuli added the skip-release This PR will be exluded from release description and doesn't trigger releasing label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-release This PR will be exluded from release description and doesn't trigger releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Akuli