Changes to how match statements interact with enums #728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things.
Compiler must know what enum values are matched
This is no longer valid:
When matching over enums, cases must be simple
EnumName.MemberName
, nothing more complicated is allowed.New UB
After this PR, the following function will invoke UB if you do
thingy_to_string(7 as Thingy)
:Currently the match statement does nothing, which means that the compiler should complain about how the function might not return a value. It doesn't because undefined value checks are currently missing. After this PR, the match statement invokes UB.
UB happens only in a very specific scenario:
case _
match
statement is not one of the enum membersI will document this (and other match statement things) in next PR.