Skip to content

Commit

Permalink
Use more descriptive names
Browse files Browse the repository at this point in the history
Signed-off-by: Alan Jowett <[email protected]>
  • Loading branch information
Alan Jowett committed Oct 14, 2024
1 parent 3838c05 commit 00963e5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
configurations: [Debug, Release]
build_tests: [build_tests, build_library]
build: [library_and_tests, library]
runs-on: ubuntu-latest
env:
# Configuration type to build. For documentation on how build matrices work, see
Expand All @@ -38,7 +38,7 @@ jobs:
- name: Build
run: |
mkdir build
if [ "${{matrix.build_tests}}" = "build_library" ]; then
if [ "${{matrix.build_tests}}" = "library" ]; then
cmake -B build -DCMAKE_BUILD_TYPE=${{env.BUILD_CONFIGURATION}} -DVERIFIER_ENABLE_TESTS=OFF
else
cmake -B build -DCMAKE_BUILD_TYPE=${{env.BUILD_CONFIGURATION}} -DVERIFIER_ENABLE_TESTS=ON
Expand All @@ -50,7 +50,7 @@ jobs:
run: ./tests -d yes

- name: Test for memory leaks
if: matrix.build_tests
if: ${{matrix.build == 'library_and_tests'}}
# Any memory leaks will cause the test to fail
# This BPF program was chosen because it is the largest one in the repo
run: valgrind --leak-check=full --errors-for-leak-kinds=all --show-leak-kinds=all --error-exitcode=1 ./check ebpf-samples/cilium/bpf_xdp_snat_linux_v1.o 2/1
Expand Down Expand Up @@ -82,5 +82,5 @@ jobs:
cmake --build build -j $(nproc) --config ${{env.BUILD_CONFIGURATION}}
- name: Run unit tests
if: matrix.build_tests
if: ${{matrix.build == 'library_and_tests'}}
run: ./${{env.BUILD_CONFIGURATION}}/tests -d yes

0 comments on commit 00963e5

Please sign in to comment.