refactor: generating selectors only once

improved perfomance. previously selector hooks were re-generated on every call to store
Albert-Gao · Jun 6, 2024 · a8635c4 · a8635c4
1 parent bf1cb1c
commit a8635c4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/createSelectorFunctions.ts b/src/createSelectorFunctions.ts
@@ -15,11 +15,9 @@ export function createSelectorFunctions<StateType extends object>(
 
   Object.keys(storeIn.getState()).forEach((key) => {
     const selector = (state: StateType) => state[key as keyof StateType];
-    storeIn.use[key] = () => {
-      return typeof storeIn === 'function'
-        ? storeIn(selector)
-        : useStore(storeIn, selector as any);
-    };
+    storeIn.use[key] = typeof storeIn === 'function'
+      ? () => storeIn(selector)
+      : () => useStore(storeIn, selector as any);
   });
 
   return store as UseBoundStore<StoreApi<StateType>> &

diff --git a/src/createSelectorHooks.ts b/src/createSelectorHooks.ts
@@ -15,11 +15,9 @@ export function createSelectorHooks<StateType extends object>(
 
   Object.keys(storeIn.getState()).forEach((key) => {
     const selector = (state: StateType) => state[key as keyof StateType];
-    storeIn[`use${capitalize(key)}`] = () => {
-      return typeof storeIn === 'function'
-        ? storeIn(selector)
-        : useStore(storeIn, selector as any);
-    };
+    storeIn[`use${capitalize(key)}`] = typeof storeIn === 'function'
+      ? () => storeIn(selector)
+      : () => useStore(storeIn, selector as any);
   });
 
   return storeIn as UseBoundStore<StoreApi<StateType>> &