[Perf] Avoid fetching already seen Certificates #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
commented
Nov 19, 2024
| continue; | ||
| } | ||
| // If we have not fully processed the certificate yet, store it. | ||
| if let Some(certificate) = self.storage.get_unprocessed_certificate(*certificate_id) { |
There was a problem hiding this comment.
NOTE: we can additionally resolve any outstanding certificate requests for this particular certificate.
vicsn
changed the title
raychu86
reviewed
Nov 25, 2024
| // Ensure storage does not already contain the certificate. | ||
| if self.storage.contains_certificate(certificate.id()) { | ||
| return Ok(()); | ||
| // Otherwise, ensure ephemeral storage contains the certificate. | ||
| } else if !self.storage.contains_unprocessed_certificate(certificate.id()) { | ||
| self.storage.insert_unprocessed_certificate(certificate.clone())?; |
There was a problem hiding this comment.
Why is the certificate not removed from the unprocessed_certificates cache when this function is completed?
There was a problem hiding this comment.
It is removed from the cache if the certificate is inserted into storage, so even sooner than waiting for the function to complete.
You might wonder whether a malicious validator could fill up the cache, and they could. The cache helps in the optimistic case to speed up processing.
raychu86
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To reduce the chance validators have to fetch any certificates, this PR ensures they don't just check their storage of confirmed certificates, but also a cache of certificates which are currently being processed.
This PR is meant not to change any consensus logic.
The second commit is a small optimization to reduce temporary allocations.
Test Plan