Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion for further investigation, so I'm filing it as a draft. It builds on https://github.com/AleoHQ/snarkVM/pull/2150 with the final commit being new.
In
compress_elements
, which only ever gets called frompush_elements_to_sponge
, the second tuple members (first.1
andsecond.1
) are alwaysF::one
, which means that:push_elements_to_sponge
(only limbs)overhead
calculation only needs to be performed onceThis is not a viable approach if we want
compress_elements
to be callable from outside ofpush_elements_to_sponge
etc, but if this is not expected, it would be a simple win for perf and clarity.