[Fix] Set console caller and signer when executing closures. #2525
Conversation
| use circuit::Eject; | ||
|
|
||
| // Set the transaction signer. | ||
| registers.set_signer(signer.eject_value()); |
There was a problem hiding this comment.
Can you wrap the two new sets with if let CallStack::Execute(..) = registers.call_stack() just like we do below? Then we can keep the use Eject to just within the Execute blocks. I hope the tests still pass then O:)
There was a problem hiding this comment.
Do we actually want to do that? In the corresponding logic in execute_function we set in all modes, not just CallStack::Execute.
There was a problem hiding this comment.
Hmm good call out. I guess we can leave the PR as is then.
I appended a diff to test if wrapping all of the console sets in Execute mode would work, and indeed the tests still pass (modulo requiring new expectations because I changed a test). Maybe this can inform a hypothetical future refactor of execute_{function, closure}.
This PR ensures that the console
callerandsignerregisters are appropriately set when executing aclosure.The CI run is here.