Expose all parallelization utility functions #2576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
approved these changes
Nov 19, 2024
| cfg_reduce, | ||
| cfg_reduce_with, | ||
| cfg_sort_by_cached_key, | ||
| cfg_sort_unstable_by, |
There was a problem hiding this comment.
This one shouldn't be exposed as the documentation states it may not preserve order of equal elements. Exposing that makes me uncofmortable.
Suggested change
| cfg_sort_unstable_by, |
There was a problem hiding this comment.
That quality is perfectly fine in almost all scenarios, and it's faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Came across this when trying to parallelize stuff in snarkOS, and realized I couldn't access all known functions.
Test Plan
No tests needed, only changes exposed functions.